Re: [Xen-devel] [PATCH v2 2/9] xen: arm: Implement variable levels in dump_pt_walk

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Ian,

On 04/09/14 09:14, Ian Campbell wrote:
> -void dump_pt_walk(lpae_t *first, paddr_t addr)
> +void dump_pt_walk(lpae_t *root, paddr_t addr,
> +                  unsigned int root_level)
>   {
> -    lpae_t *second = NULL, *third = NULL;
> +    static const char *level_strs[4] = { "0TH", "1ST", "2ND", "3RD" };
> +    const unsigned int offsets[4] = {
> +        zeroeth_table_offset(addr),
> +        first_table_offset(addr),
> +        second_table_offset(addr),
> +        third_table_offset(addr)
> +    };
> +    lpae_t pte, *mappings[4] = { 0, };
Xen never maps the next level when level == 3, shoudn't mappings[3] enough?

[..]

> +    /* mappings[root_level] is provided by the caller so don't unmap that */
> +    do
> +    {
> +        unmap_domain_page(mappings[level]);
> +    }
> +    while( level-- > root_level );
NIT: It looks like we commonly use the coding style

do
{
} while ( ... )

Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel