Re: [Xen-devel] [PATCH v2 2/9] xen: arm: Implement variable levels in dump_pt_walk

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Ian,

I forgot one point on my previous mail.

On 04/09/14 09:14, Ian Campbell wrote:
> -    if ( first_table_offset(addr) >= LPAE_ENTRIES )
> -        return;
> +    mappings[root_level] = root;
> +
> +    for ( level = root_level; ; level++ )
> +    {
I would add the check "level < 3" or an ASSERT in the beginning of the 
loop. So we could catch a possible overflow on offsets later if someone 
decide to modify it.
Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel