Re: [Xen-devel] [PATCH RFC 21/23] gdbsx: remove cast from ioctl

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2014-04-17 at 18:17 +0100, Ian Jackson wrote:
> Roger Pau Monne writes ("[PATCH RFC 21/23] gdbsx: remove cast from ioctl"):
> > The ulong type is not defined on FreeBSD, and the cast seems
> > pointless, so just remove it.
> 
> I think this is very likely to be correct.

The danger is systems where sizeof(ulong) != sizeof(struct somehing *).
I think we can sleep easy and not worry about that.

> Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

Agreed. Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel