Re: [Xen-devel] [PATCH RFC 20/23] xenstat: add a dummy FreeBSD implementation

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2014-04-16 at 16:13 +0200, Roger Pau Monne wrote:
> Add an empty FreeBSD implementation so xenstat can compile on FreeBSD.
> 
> Signed-off-by: Roger Pau Monnà <roger.pau@xxxxxxxxxx>
> Cc: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
> Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
> ---
>  tools/xenstat/libxenstat/Makefile              |    1 +
>  tools/xenstat/libxenstat/src/xenstat_freebsd.c |   47 
> ++++++++++++++++++++++++
>  2 files changed, 48 insertions(+), 0 deletions(-)
>  create mode 100644 tools/xenstat/libxenstat/src/xenstat_freebsd.c
> 
> diff --git a/tools/xenstat/libxenstat/Makefile 
> b/tools/xenstat/libxenstat/Makefile
> index 21aad89..15dc22d 100644
> --- a/tools/xenstat/libxenstat/Makefile
> +++ b/tools/xenstat/libxenstat/Makefile
> @@ -32,6 +32,7 @@ OBJECTS-y=src/xenstat.o
>  OBJECTS-$(CONFIG_Linux) += src/xenstat_linux.o
>  OBJECTS-$(CONFIG_SunOS) += src/xenstat_solaris.o
>  OBJECTS-$(CONFIG_NetBSD) += src/xenstat_netbsd.o
> +OBJECTS-$(CONFIG_FreeBSD) += src/xenstat_freebsd.o

How about doing this as a xenstat_unimplemented.c?

On the other hand I suppose this will go away before too long and be
replaced with a proper one.

>  SONAME_FLAGS=-Wl,$(SONAME_LDFLAG) -Wl,libxenstat.so.$(MAJOR)
>  
>  WARN_FLAGS=-Wall -Werror
> diff --git a/tools/xenstat/libxenstat/src/xenstat_freebsd.c 
> b/tools/xenstat/libxenstat/src/xenstat_freebsd.c
> new file mode 100644
> index 0000000..0c488df
> --- /dev/null
> +++ b/tools/xenstat/libxenstat/src/xenstat_freebsd.c
> @@ -0,0 +1,47 @@
> +/* libxenstat: statistics-collection library for Xen
> + * Copyright (C) International Business Machines Corp., 2005
> + * Authors: Josh Triplett <josht@xxxxxxxxxx>
> + *          Judy Fischbach <jfisch@xxxxxxxxxx>
> + *          David Hendricks <dhendrix@xxxxxxxxxx>

Truely?

> + *
> + * This library is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU Lesser General Public
> + * License as published by the Free Software Foundation; either
> + * version 2.1 of the License, or (at your option) any later version.
> + *
> + * This library is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> + * Lesser General Public License for more details.
> + */
> +
> +/*
> + * Copyright 2007 Sun Microsystems, Inc.  All rights reserved.
> + * Use is subject to license terms.

Really?



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel