Re: [Xen-devel] [PATCH v2 2/3] x86/boot: Move some __high_start code and data into init sections

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 28.04.14 at 16:09, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 28/04/14 15:04, Jan Beulich wrote:
>>>>> On 28.04.14 at 15:06, <andrew.cooper3@xxxxxxxxxx> wrote:
>>> --- a/xen/arch/x86/boot/x86_64.S
>>> +++ b/xen/arch/x86/boot/x86_64.S
>>> @@ -29,7 +29,11 @@
>>>  
>>>          test    %ebx,%ebx
>>>          jnz     start_secondary
>>> +        jmp     start_bsp
>>>  
>>> +        .section .init.text, "ax", @progbits
>>> +
>>> +GLOBAL(start_bsp)
>> I'm sorry, I'm afraid I overlooked this in v1 - why GLOBAL()? (The other
>> two patches look fine to me now, so no need to re-send those in case
>> this one needs changing.)
> 
> There is an explanation below the --- in the patch.

Oops, sorry, stopped reading that part after the v2 sentence.

> The issues is that start_bsp and trampoline_end have the same address,
> leading to a confusing disassembly.

Is that really defined behavior - trampoline_end is a global too? Which
one would get used if their addresses are the same may depend on
both linker and disassembler. I therefore don't agree to this needless
global.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel