Re: [Xen-devel] [PATCH RFC 19/23] hvmloader: remove size_t typedef and include stddef.h

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2014-04-16 at 16:13 +0200, Roger Pau Monne wrote:
> The open coded typedef of size_t was clashing with the typedef in
> FreeBSD headers. Remove the typedef and include the proper header
> where size_t is defined (stddef.h).
> 
> Signed-off-by: Roger Pau Monnà <roger.pau@xxxxxxxxxx>
> Cc: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
> Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
> ---
>  tools/firmware/hvmloader/util.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/tools/firmware/hvmloader/util.h b/tools/firmware/hvmloader/util.h
> index 9ccb905..46d32b9 100644
> --- a/tools/firmware/hvmloader/util.h
> +++ b/tools/firmware/hvmloader/util.h

> @@ -3,6 +3,7 @@
>  
>  #include <stdarg.h>
>  #include <stdint.h>
> +#include <stddef.h>

This isn't really userspace code, it's essentially a little kernel. So
I'm not sure what the impact of including stddef.h is. I suppose it is
probably OK.

Xen itself seems to use "typedef __SIZE_TYPE__ size_t" without
ill-affects, on *BSD too I suppose.

>  #include <xen/xen.h>
>  #include <xen/hvm/hvm_info_table.h>
>  
> @@ -174,7 +175,6 @@ int printf(const char *fmt, ...) __attribute__ ((format 
> (printf, 1, 2)));
>  int vprintf(const char *fmt, va_list ap);
>  
>  /* Buffer output */
> -typedef unsigned long size_t;
>  int snprintf(char *buf, size_t size, const char *fmt, ...) __attribute__ 
> ((format (printf, 3, 4)));
>  
>  /* Populate specified memory hole with RAM. */



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel