[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH RFC 21/23] gdbsx: remove cast from ioctl



On Mon, 28 Apr 2014 15:46:26 +0100
Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:

> On Thu, 2014-04-17 at 18:17 +0100, Ian Jackson wrote:
> > Roger Pau Monne writes ("[PATCH RFC 21/23] gdbsx: remove cast from
> > ioctl"):
> > > The ulong type is not defined on FreeBSD, and the cast seems
> > > pointless, so just remove it.
> > 
> > I think this is very likely to be correct.
> 
> The danger is systems where sizeof(ulong) != sizeof(struct somehing
> *). I think we can sleep easy and not worry about that.
> 
> > Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> 
> Agreed. Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> 
> Ian.

Acked-by: Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.