Re: [Xen-devel] MPIDR register usage in ARMv8

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2014-04-16 at 14:58 +0530, Vijay Kilari wrote:
> > Except the MPIDR_HWID_MASK I don't see any problem as the only difference
> > between ARMv8 and ARMv7 is adding a new affinity field (AFF3).
> 
> Thanks. Yes, I will send a patch. I will move these MPIDR definitions
> from include/asm-arm/processor.h
> to include/asm-arm/arm32/processor.h & include/asm-arm/arm64/processor.h

I don't think that is strictly necessary, something like:

#define MPIDR_AFF0_SHIFT    (0)
#define MPIDR_AFF0_MASK     (_AC(0xff,U) << MPIDR_AFF0_SHIFT)
#define MPIDR_AFF1_SHIFT    (8)
#define MPIDR_AFF1_MASK     (_AC(0xff,U) << MPIDR_AFF1_SHIFT)
#define MPIDR_AFF2_SHIFT    (16)
#define MPIDR_AFF2_MASK     (_AC(0xff,U) << MPIDR_AFF2_SHIFT)
#define MPIDR_AFF3_SHIFT    (32)
#define MPIDR_AFF3_MASK     (_AC(0xff,U) << MPIDR_AFF3_SHIFT)
#ifdef CONFIG_ARM_32
#define MPIDR_HWID_MASK     MPIDR_AFF0_MASK|MPIDR_AFF1_MASK|MPIDR_AFF2_MASK
else
#define MPIDR_HWID_MASK     
MPIDR_AFF0_MASK|MPIDR_AFF1_MASK|MPIDR_AFF2_MASK|MPIDR_AFF3_MASK
#endif
#define MPIDR_INVALID       (~MPIDR_HWID_MASK)

would be fine I think.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel