[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] (XEN) [2013-08-23 12:23:26] Assertion 'entry->pirq == pirq' failed at vmsi.c

>>> On 23.08.13 at 15:26, Sander Eikelenboom <linux@xxxxxxxxxxxxxx> wrote:
> I have adjusted the debug patch, only letting it reuse the entry if ( pdev 
> == entry->pdev && entry->pirq == pirq){
> so the assertion should be always true now, would this perhaps be the proper 
> fix or should it also check if it is also masked ?

Yes, that might be a possible solution, albeit I don't like it - it points
out that the original patch from Joby is - beyond the bug here - at
least inefficient (in that we'd then allocate an entry per MSI-X table
entry, i.e. per IRQ, instead of per device). I therefore think we
rather ought to revert that change, and have him redo it properly.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.