Re: [Xen-devel] [PATCH] Fix cd-insert problem not detecting type.

[Frediano Ziglio <frediano.ziglio@xxxxxxxxxx>]

On Tue, 2013-03-19 at 13:48 +0000, Stefano Stabellini wrote:
> On Fri, 15 Mar 2013, Frediano Ziglio wrote:
> > On Fri, 2013-03-15 at 14:51 +0000, Stefano Stabellini wrote:
> > > On Tue, 12 Mar 2013, Frediano Ziglio wrote:
> > > > In 4.1 you could use prefixes that using a regex are
> > > > 
> > > > (phy|file|tap2?:(aio:)?(vhd|qcow|qcow2|raw)):
> > > > 
> > > > you could use similar syntax in Xml file. If you run just "xl cd-insert"
> > > > output is
> > > 
> > > XML file? Are you sure that you are talking about xl and xm or something
> > > else?
> > > 
> > 
> > Was xl configuration files.
> 
> I didn't know that something like 
> 
> (phy|file|tap2?:(aio:)?(vhd|qcow|qcow2|raw))
> 
> is supported in the VM  config file.
> Maybe with xend, but certainly it can't be the case with XL.
> 
> 

Look at parse_disk_config in tools/libxl/xl_cmdimpl.c in 4.1 release.

> 
> > > > By the way, do we want to break cd-insert command line syntax or just
> > > > add a new format?
> > > > Or is it better to add a new "block-change" command?
> > > > Currently using 4.2 you can't specify as many format as 4.1.
> > > 
> > > I would hate to have to introduce yet another command to work around a
> > > broken one.
> > > I would rather break compatibility with the existing cd-insert.
> > 
> > I would be all right with you if we removed supported for this syntax
> > but as xl configurations files are still supported with this syntax I
> > prefer to not change cd-insert one.
> 
> Sorry but I can't parse what you wrote.
> Also, as I wrote above, I don't think that
> 
> (phy|file|tap2?:(aio:)?(vhd|qcow|qcow2|raw))
> 
> is supported (or should be supported) by xl

Was supported in 4.1 and still xl command state that syntax is
type:path. Configuration file still accept syntax like
'raw:/mnt/win7-x86.iso,hdd:cdrom,r' for disks even on last xen unstable.

Frediano

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel