Re: [Xen-devel] [PATCH] Fix cd-insert problem not detecting type.

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Frediano Ziglio writes ("Re: [PATCH] Fix cd-insert problem not detecting 
type."):
> I think that changing XLU code (libxlu_disk_l.l) could just make some
> other code break or move the parser back.

I don't think we need to substantially change the existing parser.  I
think we need to make sure we use it in the normal way.

>   I think we should keep the
> command line syntax compatibility

Well, currently the command line syntax doesn't support "raw:<blah>"
etc. which is what you are trying to introduce.  "raw:<blah>" would
mean a file whose name starts "raw..." etc.  So it is not possible to
make your use case work without breaking some obscure cases.

My proposal is that we should bite this bullet and regularise the
parsing, so that xl cd-insert takes the same kind of argument as xl
block-attach.

>   while updating internal code so perhaps the better option is to
> detect is user tried to give a specific type and add the correct
> "format" option to pass to parse_disk_config.  If you agree with
> this I can write a patch. Is not clear however which "types" are
> supported for xl cd-insert command. It seems a mix of backend (like
> "phy") and formats (like "raw"). Is this expected?

These "types" are a xend thing and are indeed a mixture of backend,
format, and other information.  In xl they are supported (where they
are) for backward compatibility, but they are not recommended.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel