[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] Fix cd-insert problem not detecting type.

Frediano Ziglio writes ("[PATCH] Fix cd-insert problem not detecting type."):
> String format used to parse file used target which does not handle
> types. Append directly argument passes to command line so parser
> handle type correctly.

Thanks for pointing out this problem.

The problem here seems to be that "xl cd-insert" takes a <target>.
This is documented.  Your change would break some existing setups
(where the <target> passed contained certain metacharacters).

But I think the current definition of "xl cd-insert" is wrongheaded.
It should surely take a whole block device specification, with a
special option passed to the parser to force "cdrom", and another
special option passed to the parser to stop it failing if vdev isn't

The caller should check that the vdev is either unspecified or
specifies the same device.

In any case, I think the approach in the existing code of trying to
unparse the user-supplied target into a string for the benefit of
parse_disk_config is wrong.

What do other people think about this ?


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.