[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH] Fix cd-insert problem not detecting type.

String format used to parse file used target which does not handle
types. Append directly argument passes to command line so parser
handle type correctly.

The issue was caused by setting pdev_path with type:file which was
used to stat the file.

Signed-off-by: Frediano Ziglio <frediano.ziglio@xxxxxxxxxx>
 tools/libxl/xl_cmdimpl.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
index a98705e..5d4fb39 100644
--- a/tools/libxl/xl_cmdimpl.c
+++ b/tools/libxl/xl_cmdimpl.c
@@ -2519,7 +2519,7 @@ static void cd_insert(uint32_t domid, const char
*virtdev, char *phys)
     XLU_Config *config = 0;

-    if (asprintf(&buf, "vdev=%s,access=r,devtype=cdrom,target=%s",
+    if (asprintf(&buf, "vdev=%s,access=r,devtype=cdrom,%s",
                  virtdev, phys ? phys : "") < 0) {
         fprintf(stderr, "out of memory\n");

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.