[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 1/2] Xen acpi pad implement

> > +config XEN_ACPI_PAD_STUB
> > +   bool
> > +   depends on XEN_DOM0 && X86_64 && ACPI
> > +   default n
> > +
> This Kconfig is pointless, if CONFIG_XEN_ACPI_PAD_STUB = n, native pad would 
> successfully registerred, and then mwait #UD (we would revert 
> df88b2d96e36d9a9e325bfcd12eb45671cbbc937, right?). So xen stub logic should 
> unconditionally built-in kernel.

Potentially. Keep in mind that there is no need to built this if the
kernel is not built with ACPI.
.. snip.
> > +subsys_initcall(xen_acpi_pad_stub_init);
> I'm still confused. In this way there are xen-acpi-pad-stub.c and 
> xen-acpi-pad.c, and you want to let xen-acpi-pad loaded as module, right? how 
> can xen-acpi-pad logic work when it was insmoded?

Via the register/unregister calls that this provides? Or does ACPI bus
drivers get immediately called once the call acpi_bus_register_driver?

Or can one 'poke' the 'add' and 'remove' calls so that once the "true"
PAD driver is loaded it will restart the ops->add call?

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.