Re: [Xen-devel] [PATCH 1/2] Xen acpi pad implement

["Liu, Jinsong" <jinsong.liu@xxxxxxxxx>]

Thanks! updated accordingly, w/ 2 comments left as below:

> +static const struct acpi_device_id pad_device_ids[] = {
> +     {"ACPI000C", 0},
> +     {"", 0},
> +};
> +
> +static struct acpi_driver xen_acpi_pad_driver = {
> +     .name = "processor_aggregator",
> +     .class = ACPI_PROCESSOR_AGGREGATOR_CLASS,
> +     .ids = pad_device_ids,
> +     .ops = {
> +             .add = xen_acpi_pad_add,

.remove?

[Jinsong] .remove method not used by any logic now (any possible point use 
it?), so we remove it from our former patch.

> +     },
> +};
> +
> +static int __init xen_acpi_pad_init(void)
> +{
> +     /* Only DOM0 is responsible for Xen acpi pad */
> +     if (xen_initial_domain())
> +             return acpi_bus_register_driver(&xen_acpi_pad_driver);
> +
> +     return -ENODEV;
> +}
> +subsys_initcall(xen_acpi_pad_init);
> +
> +#endif

Overall I'd recommend taking a look at the cleaned up driver in
our kernels.

[Jinsong] What's your point here?

Thanks,
Jinsong

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel