Re: [Xen-devel] [PATCH 1/2] Xen acpi pad implement

["Jan Beulich" <jbeulich@xxxxxxxx>]

>>> "Liu, Jinsong" <jinsong.liu@xxxxxxxxx> 10/26/12 8:18 AM >>>
>> +static struct acpi_driver xen_acpi_pad_driver = {
>> +    .name = "processor_aggregator",
>> +    .class = ACPI_PROCESSOR_AGGREGATOR_CLASS,
>> +    .ids = pad_device_ids,
>> +    .ops = {
>> +        .add = xen_acpi_pad_add,
>
>.remove?
>
>[Jinsong] .remove method not used by any logic now (any possible point use 
>it?), so we remove it from our former patch.

Unless there is technical difficulty implementing it, I wouldn't defer adding 
that code until the point where something doesn't work anymore.

>Overall I'd recommend taking a look at the cleaned up driver in
>our kernels.
>
>[Jinsong] What's your point here?

There's quite a bit of cleanup/simplification potential here, and rather than 
pointing the pieces out individually I would think comparing with what we have 
in production use might be worthwhile. But that's up to you of course.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel