Re: [Xen-devel] [PATCH 08/13] Xen paravirtualised PCI hotplug.

[Vincent Hanquez <vincent.hanquez@xxxxxxxxxxxxx>]

Konrad Rzeszutek Wilk wrote:
> The pciback driver adds two new states that are shared by the pcifront
> and pciback. This is a patch pulled from the linux-2.6-xen-sparse tree.
>
> Signed-off-by: Yosuke Iwamatsu <y-iwamatsu@xxxxxxxxxxxxx>
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> ---
>  include/xen/interface/io/xenbus.h |    8 +++++++-
>  1 files changed, 7 insertions(+), 1 deletions(-)
>
> diff --git a/include/xen/interface/io/xenbus.h 
> b/include/xen/interface/io/xenbus.h
> index 46508c7..9fda532 100644
> --- a/include/xen/interface/io/xenbus.h
> +++ b/include/xen/interface/io/xenbus.h
> @@ -27,8 +27,14 @@ enum xenbus_state
>         XenbusStateClosing      = 5,  /* The device is being closed
>                                          due to an error or an unplug
>                                          event. */
> -       XenbusStateClosed       = 6
> +       XenbusStateClosed       = 6,
>  
> +	/*
> +       * Reconfiguring: The device is being reconfigured.
> +       */
> +       XenbusStateReconfiguring = 7,
> +
> +       XenbusStateReconfigured  = 8
>  };
>   
ouch.

what's the usefulness of those 2 new states here ?
the xenbus state is just here to represent the connection status of the 
xenbus device, doesn't reconfiguring/reconfigured state is something 
about the underlying device more than the xenbus device ?
And regarding the xenbus-state state machine, what happen when you reach 8 ?
does every userspace handler need to handle it as a 4 ? if yes why is it 
not 4 ?
--
Vincent

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel