Re: [XenPPC] [pushed] [ppc] serialize the processor for debugging purposes and print out HID0

[Hollis Blanchard <hollisb@xxxxxxxxxx>]

On Tue, 2006-04-25 at 16:41 -0400, Jimi Xenidis wrote:
> On Apr 25, 2006, at 3:51 PM, Hollis Blanchard wrote:
> > Please fix the // comments and spacing mismatch.
> oops, yes I hate them to.
> >
> > Also, I'm completely baffled... why did you add all these magic  
> > numbers
> > instead of simply extending "union hid0"? Please fix.
> because they are not necessarily architected bit, so I'd rather leave  
> them for debug.

If you really object to placing them in the structure (which I don't
understand), then the least you could do is define some constant names
for them. Then you could define an HID0_EXTRABITS macro:
        #define SERIALIZE
        #ifdef SERIALIZE
        #define HID0_EXTRABITS HID0_SOMETHING | HID0_SOMETHING_ELSE
        #else
        #define HID0_EXTRABITS 0
        #endif

-- 
Hollis Blanchard
IBM Linux Technology Center


_______________________________________________
Xen-ppc-devel mailing list
Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ppc-devel