Re: [XenPPC] [pushed] [ppc] serialize the processor for debugging purposes and print out HID0

[Hollis Blanchard <hollisb@xxxxxxxxxx>]

On Tue, 2006-04-25 at 14:14 -0400, Jimi Xenidis wrote:
> changeset:   9947:d82fb1f2e3325bdb61a8a97043dff88ba5e7b442
> user:        jimix@xxxxxxxxxxxxxxxxxxxxx
> date:        Tue Apr 18 14:51:30 2006 -0400
> files:       xen/arch/ppc/ppc64/ppc970.c
> description:
> [ppc] serialize the processor for debugging purposes and print out HID0
> 
> 
> diff -r 16f3d0fb6c7d0208d92bccf5e3db8e62a6a14c88 -r 
> d82fb1f2e3325bdb61a8a97043dff88ba5e7b442 xen/arch/ppc/ppc64/ppc970.c
> --- a/xen/arch/ppc/ppc64/ppc970.c     Tue Apr 18 13:04:42 2006 -0400
> +++ b/xen/arch/ppc/ppc64/ppc970.c     Tue Apr 18 14:51:30 2006 -0400
> @@ -26,6 +26,8 @@
>  #include <asm/ppc64/procarea.h>
>  #include <asm/ppc64/processor.h>
>  #include <asm/ppc64/ppc970-hid.h>
> +
> +#undef SERIALIZE
>  
>  void cpu_initialize(void)
>  {
> @@ -58,6 +60,17 @@ void cpu_initialize(void)
>      hid0.bits.hdice = 1; /* enable HDEC */
>      hid0.bits.eb_therm = 1;
>      hid0.bits.en_attn = 1;
> +#ifdef SERIALIZE
> +    ulong s = 0;
> +
> +    s |= 1UL << (63-0);     /* one_ppc */
> +//    s |= 1UL << (63-1);     /* do_single */
> +    s |= 1UL << (63-2);     /* isync_sc */
> +//    s |= 1UL << (63-3);     /* ser-gp */
> +    s |= 1UL << (63-16);     /* inorder */
> +    hid0.word |= s;
> +#endif
> +    printk("hid0: 0x%016lx\n", hid0.word);
>      mthid0(hid0.word);
>  
>      union hid1 hid1;

Please fix the // comments and spacing mismatch.

Also, I'm completely baffled... why did you add all these magic numbers
instead of simply extending "union hid0"? Please fix.

-- 
Hollis Blanchard
IBM Linux Technology Center


_______________________________________________
Xen-ppc-devel mailing list
Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ppc-devel