[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XenPPC] [pushed] [ppc] serialize the processor for debugging purposes and print out HID0

To: Hollis Blanchard <hollisb@xxxxxxxxxx>
From: Jimi Xenidis <jimix@xxxxxxxxxxxxxx>
Date: Tue, 25 Apr 2006 16:41:08 -0400
Cc: xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 25 Apr 2006 13:41:20 -0700
List-id: Xen PPC development <xen-ppc-devel.lists.xensource.com>


On Apr 25, 2006, at 3:51 PM, Hollis Blanchard wrote:

Please fix the // comments and spacing mismatch.

oops, yes I hate them to.

Also, I'm completely baffled... why did you add all these magicnumbers
instead of simply extending "union hid0"? Please fix.

because they are not necessarily architected bit, so I'd rather leavethem for debug.

-JX


_______________________________________________
Xen-ppc-devel mailing list
Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ppc-devel

Follow-Ups:
- Re: [XenPPC] [pushed] [ppc] serialize the processor for debugging purposes and print out HID0
  - From: Olof Johansson
- Re: [XenPPC] [pushed] [ppc] serialize the processor for debugging purposes and print out HID0
  - From: Hollis Blanchard

References:
- [XenPPC] [pushed] [ppc] serialize the processor for debugging purposes and print out HID0
  - From: Jimi Xenidis
- Re: [XenPPC] [pushed] [ppc] serialize the processor for debugging purposes and print out HID0
  - From: Hollis Blanchard

Prev by Date: Re: [Xen-devel] [patch] 32/64-bit hypercall interface revisited
Next by Date: Re: [XenPPC] [pushed] [ppc] OF write method does not handle carriage return
Previous by thread: Re: [XenPPC] [pushed] [ppc] serialize the processor for debugging purposes and print out HID0
Next by thread: Re: [XenPPC] [pushed] [ppc] serialize the processor for debugging purposes and print out HID0
Index(es):
- Date
- Thread

Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.