RE: [Xen-ia64-devel] RFC: adding a dom0_firmware_setup hypercall

["Tian, Kevin" <kevin.tian@xxxxxxxxx>]

>From: Tristan Gingold
>Sent: 2006年5月23日 22:25
>Hi,
>
>this a just for review and comments.  The purpose is not to use
>DOM0_SETVPUCONTEXT to initialiaze a domain.
>This is the first step for save&restore.

Since it's a RFC, it's better if, you could give more detail description 
about why you need this change and what benefit people can achieve 
from. For example:
        - Why do you like to kill DOM0_SETVPUCONTEXT, which has 
common concept and has been used for ia64 now?
        - Why is it the first step toward save&restore?
        - ...
Based on those information, people can better understand your 
proposal and thus give appropriate comments.

BTW, why can't those new fields (or whole firmware setup structure) be 
put in vcpu_guest_context without adding a new dom0_op?

>
>[This patch also contains warning cleanup, it will be separated of
>course].

It's still better if you could remove hunks which only contains warning 
cleanup, and then make people further focusing the very content you 
like others to review. :-)

Thanks,
Kevin

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel