[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 03/42] xen/riscv: introduce csr_volatile_read64()


  • To: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 18 Nov 2026 11:57:42 +0100
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID"
  • Autocrypt: addr=jbeulich@xxxxxxxx; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Romain Caritey <Romain.Caritey@xxxxxxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monné <roger@xxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Baptiste Le Duc <baptiste.le-duc@xxxxxxxxxx>
  • Delivery-date: Wed, 18 Nov 2026 10:57:51 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 18.11.2026 11:49, Jan Beulich wrote:
> On 18.11.2026 10:50, Baptiste Le Duc wrote:
>>> On RV32 a 64-bit CSR is accessed as two halves, <csr> and <csr>H. Reading
>>> the halves with two separate instructions isn't always safe: for a CSR
>>> which hardware increments, a carry from the low half into the high one can
>>> happen in between, so a plain pair of reads can produce a value the CSR
>>> never held. Therefore the high half is re-read and the sequence retried if
>>> it changed in the meantime.
>>>
>>> Only CSRs which change under Xen's feet need that, hence the name. The
>>> majority can be read with a plain pair of csr_read()s, so no helper for
>>> those is introduced here as there would be no user for it.
>>>
>>> Use it for CSR_TIME, which is exactly such a counter, and widen cycles_t to
>>> uint64_t. Otherwise get_cycles() would still truncate the time counter to
>>> 32 bits on RV32.
>>>
>>> No functional change on RV64.
>>>
>>> Fixes: a541ddadec0a ("xen/riscv: introduce time.h")
>>> Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
>>> ---
>>> Changes in v4:
>>>  - Take the CSR name without the CSR_ prefix, so that the macro parameter
>>>    is used as an operand of ## only (MISRA C Rule 20.12).
>>>  - Drop the (void) of the ...H constant on RV64.
>>>  - Initialise hi_ in its declaration.
>>
>> Jan gave his Reviewed-by on v3. It is gone in v4. Dropping it may be
>> fine given the macro rework, but please say so in the changelog :)
>>
>>> [ ... 45 lines skipped ... ]
>>>  #else
>>>  #define csr_write64(name, val) csr_write(CSR_ ## name, val)
>>> +
>>> +#define csr_volatile_read64(name) csr_read(CSR_ ## name)
>>
>> Nit: On v3 Jan suggested "#define csr_volatile_read64 csr_read64", and you
>> answered you would then move csr_read64() into this patch. In v4
>> csr_read64() still only comes with "xen/riscv: implement vCPU context
>> switching".
>>
>> On RV64 I think it would read better like that:
>> #define csr_read64(name) csr_read(CSR_ ## name)
>> #define csr_volatile_read64(name) csr_read64(name)
> 
> #define csr_read64(name) csr_read(CSR_ ## name)
> #define csr_volatile_read64 csr_read64
> 
> i.e. matching what I suggested earlier. Otherwise what is passed into
> csr_volatile_read64() would be macro-expanded before further
> expanding csr_read64(), thus prepending CSR_ only to the result of
> that expansion. (In the common case there'll be no difference, but
> things can go wrong if some unexpected new #define appears.)

Oh, and - happy to fold this in while committing (perhaps with an adjustment
to subject and description), if you agree. With that
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.