[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] nestedsvm: Ignore attempts to clear EFER.SVME from L2
- To: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Wed, 18 Nov 2026 11:24:36 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=H5b8MhhA4w8JaRbdC+99c4q+f1zq02zXE6BlR9MtDUU=; b=emxfLjNwJPpMNRxbz4ixDJBuh6ViTklXuHs3NnbxxAsK4tS1GBmFdEgt0yqpkCpvo7BHUSgo5cnVd4IbjawQfOBsYigwqS4y9wyaFUKZwnRQwPVjahhmbKfCAtWbreS8doRbtWPa1a4AwdK5V206azD39x9lIt66XZkvVZCSKN/IvUoreh7jsYa1YPyJY/+VDGgNwcTmz5fx6ntKUyv6DwLe+kUCWD24v+wPspKLfqMDFtxwtEPuHLCaxy0aBan46hMYXDhL6cT/ifMDowIaRfTDZUFbL3OK9LaWEHWVUSbeJHDjFA3/Ahq4ScsWOBfeiJg9541ww8Y11Yb8sJNNDA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ps4+0vDmKxgwr8mF/1c4QAJaozczeb9sYdSp+pRQ0SJKyJH4FilnHDZlSlLIazmcJu4m98wjhu7KmxMpwlEW16yBR6577jRawlO4F8pkxkGAt/IbBjiuRK7PXbjHKouVRHp/SxJlQEj7dTC8FacIo4xgoCe+A2Hik3IQfPLWNQm3+5Rz70psm/WbwdV/ZxFw3jKpspzubVTBVm7PEO9pPA0LhkXraw2Emrxn3WNShyzUdO9VPYoI3qI338WkhVUQPf9QNyOiN7TuYIrnQ18hAKCbAVkvNrxBN3pv0NUuLPYWMW+YNj6X/38PwBtUV3iNYCItcDvGt4kEqKzXC3no6g==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Authentication-results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Autocrypt: addr=andrew.cooper3@xxxxxxxxxx; keydata= xsFNBFLhNn8BEADVhE+Hb8i0GV6mihnnr/uiQQdPF8kUoFzCOPXkf7jQ5sLYeJa0cQi6Penp VtiFYznTairnVsN5J+ujSTIb+OlMSJUWV4opS7WVNnxHbFTPYZVQ3erv7NKc2iVizCRZ2Kxn srM1oPXWRic8BIAdYOKOloF2300SL/bIpeD+x7h3w9B/qez7nOin5NzkxgFoaUeIal12pXSR Q354FKFoy6Vh96gc4VRqte3jw8mPuJQpfws+Pb+swvSf/i1q1+1I4jsRQQh2m6OTADHIqg2E ofTYAEh7R5HfPx0EXoEDMdRjOeKn8+vvkAwhviWXTHlG3R1QkbE5M/oywnZ83udJmi+lxjJ5 YhQ5IzomvJ16H0Bq+TLyVLO/VRksp1VR9HxCzItLNCS8PdpYYz5TC204ViycobYU65WMpzWe LFAGn8jSS25XIpqv0Y9k87dLbctKKA14Ifw2kq5OIVu2FuX+3i446JOa2vpCI9GcjCzi3oHV e00bzYiHMIl0FICrNJU0Kjho8pdo0m2uxkn6SYEpogAy9pnatUlO+erL4LqFUO7GXSdBRbw5 gNt25XTLdSFuZtMxkY3tq8MFss5QnjhehCVPEpE6y9ZjI4XB8ad1G4oBHVGK5LMsvg22PfMJ ISWFSHoF/B5+lHkCKWkFxZ0gZn33ju5n6/FOdEx4B8cMJt+cWwARAQABzSlBbmRyZXcgQ29v cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPsLBegQTAQgAJAIbAwULCQgHAwUVCgkI CwUWAgMBAAIeAQIXgAUCWKD95wIZAQAKCRBlw/kGpdefoHbdD/9AIoR3k6fKl+RFiFpyAhvO 59ttDFI7nIAnlYngev2XUR3acFElJATHSDO0ju+hqWqAb8kVijXLops0gOfqt3VPZq9cuHlh IMDquatGLzAadfFx2eQYIYT+FYuMoPZy/aTUazmJIDVxP7L383grjIkn+7tAv+qeDfE+txL4 SAm1UHNvmdfgL2/lcmL3xRh7sub3nJilM93RWX1Pe5LBSDXO45uzCGEdst6uSlzYR/MEr+5Z JQQ32JV64zwvf/aKaagSQSQMYNX9JFgfZ3TKWC1KJQbX5ssoX/5hNLqxMcZV3TN7kU8I3kjK mPec9+1nECOjjJSO/h4P0sBZyIUGfguwzhEeGf4sMCuSEM4xjCnwiBwftR17sr0spYcOpqET ZGcAmyYcNjy6CYadNCnfR40vhhWuCfNCBzWnUW0lFoo12wb0YnzoOLjvfD6OL3JjIUJNOmJy RCsJ5IA/Iz33RhSVRmROu+TztwuThClw63g7+hoyewv7BemKyuU6FTVhjjW+XUWmS/FzknSi dAG+insr0746cTPpSkGl3KAXeWDGJzve7/SBBfyznWCMGaf8E2P1oOdIZRxHgWj0zNr1+ooF /PzgLPiCI4OMUttTlEKChgbUTQ+5o0P080JojqfXwbPAyumbaYcQNiH1/xYbJdOFSiBv9rpt TQTBLzDKXok86M7BTQRS4TZ/ARAAkgqudHsp+hd82UVkvgnlqZjzz2vyrYfz7bkPtXaGb9H4 Rfo7mQsEQavEBdWWjbga6eMnDqtu+FC+qeTGYebToxEyp2lKDSoAsvt8w82tIlP/EbmRbDVn 7bhjBlfRcFjVYw8uVDPptT0TV47vpoCVkTwcyb6OltJrvg/QzV9f07DJswuda1JH3/qvYu0p vjPnYvCq4NsqY2XSdAJ02HrdYPFtNyPEntu1n1KK+gJrstjtw7KsZ4ygXYrsm/oCBiVW/OgU g/XIlGErkrxe4vQvJyVwg6YH653YTX5hLLUEL1NS4TCo47RP+wi6y+TnuAL36UtK/uFyEuPy wwrDVcC4cIFhYSfsO0BumEI65yu7a8aHbGfq2lW251UcoU48Z27ZUUZd2Dr6O/n8poQHbaTd 6bJJSjzGGHZVbRP9UQ3lkmkmc0+XCHmj5WhwNNYjgbbmML7y0fsJT5RgvefAIFfHBg7fTY/i kBEimoUsTEQz+N4hbKwo1hULfVxDJStE4sbPhjbsPCrlXf6W9CxSyQ0qmZ2bXsLQYRj2xqd1 bpA+1o1j2N4/au1R/uSiUFjewJdT/LX1EklKDcQwpk06Af/N7VZtSfEJeRV04unbsKVXWZAk uAJyDDKN99ziC0Wz5kcPyVD1HNf8bgaqGDzrv3TfYjwqayRFcMf7xJaL9xXedMcAEQEAAcLB XwQYAQgACQUCUuE2fwIbDAAKCRBlw/kGpdefoG4XEACD1Qf/er8EA7g23HMxYWd3FXHThrVQ HgiGdk5Yh632vjOm9L4sd/GCEACVQKjsu98e8o3ysitFlznEns5EAAXEbITrgKWXDDUWGYxd pnjj2u+GkVdsOAGk0kxczX6s+VRBhpbBI2PWnOsRJgU2n10PZ3mZD4Xu9kU2IXYmuW+e5KCA vTArRUdCrAtIa1k01sPipPPw6dfxx2e5asy21YOytzxuWFfJTGnVxZZSCyLUO83sh6OZhJkk b9rxL9wPmpN/t2IPaEKoAc0FTQZS36wAMOXkBh24PQ9gaLJvfPKpNzGD8XWR5HHF0NLIJhgg 4ZlEXQ2fVp3XrtocHqhu4UZR4koCijgB8sB7Tb0GCpwK+C4UePdFLfhKyRdSXuvY3AHJd4CP 4JzW0Bzq/WXY3XMOzUTYApGQpnUpdOmuQSfpV9MQO+/jo7r6yPbxT7CwRS5dcQPzUiuHLK9i nvjREdh84qycnx0/6dDroYhp0DFv4udxuAvt1h4wGwTPRQZerSm4xaYegEFusyhbZrI0U9tJ B8WrhBLXDiYlyJT6zOV2yZFuW47VrLsjYnHwn27hmxTC/7tvG3euCklmkn9Sl9IAKFu29RSo d5bD8kMSCYsTqtTfT6W4A3qHGvIDta3ptLYpIAOD2sY3GYq2nf3Bbzx81wZK14JdDDHUX2Rs 6+ahAA==
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger@xxxxxxxxxxxxxx>, Teddy Astie <teddy.astie@xxxxxxxxxx>
- Delivery-date: Wed, 18 Nov 2026 11:25:01 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 13/11/2026 4:02 pm, Ross Lagerwall wrote:
> The APM leaves it undefined what happens when the VMM doesn't intercept
> writes to EFER and EFER.SVME is cleared. The current implementation in
> Xen resets the nested state without doing a VMEXIT which is unexpected
> and may potentially hit a BUG or assertion failure.
>
> Therefore, implement the same behaviour as the APM documents for SEV-ES
> guests; ignore the attempt to clear it.
I agree this is the right course of action. It's also what KVM does as
well IIRC.
>
> Signed-off-by: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
> ---
>
> Another option here could be to fail VMRUN if L1 does not intercept
> writes to EFER. However, this wouldn't match the behaviour of real
> processors and may cause incomplete toy hypervisors to unexpectedly
> fail.
>
> xen/arch/x86/hvm/hvm.c | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c
> index 71da15c0a4ed..f4155f523598 100644
> --- a/xen/arch/x86/hvm/hvm.c
> +++ b/xen/arch/x86/hvm/hvm.c
> @@ -2156,9 +2156,15 @@ int hvm_set_efer(uint64_t value)
> ((value & EFER_SVME) == 0 ) &&
> ((value ^ v->arch.hvm.guest_efer) & EFER_SVME) )
> {
> - /* Cleared EFER.SVME: Flush all nestedp2m tables */
> - p2m_flush_nestedp2m(v->domain);
> - nestedhvm_vcpu_reset(v);
> + if ( nestedhvm_vcpu_in_guestmode(v) )
> + /* Ignore attempts to clear EFER.SVME from L2 */
> + value |= EFER_SVME;
> + else
> + {
> + /* Cleared EFER.SVME: Flush all nestedp2m tables */
> + p2m_flush_nestedp2m(v->domain);
> + nestedhvm_vcpu_reset(v);
> + }
> }
>
> value |= v->arch.hvm.guest_efer & EFER_LMA;
I think this is ok, given the state of the codebase, so Reviewed-by:
Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
However, this is bad logic. nestedhvm_vcpu_reset() ultimately sets
GIF=1 and this is almost certainly not what happens in real hardware.
It also zeroes a lot of state which are by definition 0 in root mode.
It's also nasty having SVM specifics escape into common code, but it's
necessary as we're choosing to ignore in a guest-visible way. We don't
want to have two areas of code trying to decide what the eventual EFER
should be.
We'll need to fix all of this due course.
~Andrew
|