[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/arm: its: only clean cache when sending ITS command
- To: "Orzel, Michal" <michal.orzel@xxxxxxx>
- From: Daisuke Nishimura <nishimura@xxxxxxxxxxxxx>
- Date: Wed, 18 Nov 2026 09:11:12 +0900
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/m/lWMA0COO5xIxOG9xK5tZfiU4xDWQ+AevlpfzyuAo=; b=fZYw+cwSbeRAqh9lN7Zzm8mYEGiequUEOmFgLbvmLPgMJX07xMJL/9GFWMDPeg5nGeaO4HzOnLL50o7Y6hLHyDZ+su5+d/g/T3LWwO98nzuSXTIQ2u9spIhvMekSyLI24uyji17k68ixdyJouD3UAv/bNQlS5oyH2sUljChaymFTZsci3ut8EC5vd0ejb5QY9WDTVOl+kkxLXOCoUWmm/U5PfMyOv+RUTAHC7gL9IqRNyybxKnLYbDDzJxf89SifuzAspuID+/zPN9MfZcBSMktL5JULM50LFoi8xmIzoqxqeHDmTXbSuKDMWJ0/XZxBgkzx5V5vM2SbOWfzvu6dxA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dC99JJ8tM11yvcdzlOWY1IMCUiTCX3W/SnJxwN5+w4kNJmJmxXgSUHecSX05KPBJxrhmJGfnZz2jkAhf25FnrKpHJHL497+rnj59+ly6ePtwNEr6ccTLPf6mZq0I1FWLJVx649Hk2XlHEo6zsPqM2ALTOiOQfrBBEhSowIwdoub0v2+Ptq1Epn6dzrbFX/ShIARjYOH+JMm3+GoWjiTl5ndqtDa7rJayIOqjestRH4VDVSVANi8+NZT3ftSD2nKU9t9ho+ig6bydUwSCoTf5LZjDRAbe8pX4zodWTpToGOKDm8R1tztnI3QamGjVld5p41hLnGdgz7bGtL2EV879rw==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=valinux.co.jp header.i="@valinux.co.jp" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Authentication-results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp;
- Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Daisuke Nishimura <nishimura@xxxxxxxxxxxxx>
- Delivery-date: Wed, 18 Nov 2026 00:11:35 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi, Orzel.
Thank you for your review and comment.
I'll update the commit message based on your comment,
and resend the patch.
Daisuke Nishimura
On Tue, 17 Nov 2026 08:45:27 +0100
"Orzel, Michal" <michal.orzel@xxxxxxx> wrote:
>
>
> On 17-Nov-26 04:32, Daisuke Nishimura wrote:
> > From: Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>
> >
> > There is no need to invalidate cache entry because we just wrote
> > that memory. So it is guaranteed that cache entry is valid.
> I don't think this is a good rationale. What makes invalidation not
> needed here is that the CPU is the only writer and the ITS the only
> reader of this buffer, so the cached data cannot be stale.
> Invalidation would be needed if a device wrote a buffer that the CPU
> later reads.
>
> >
> > But we need to clean (flush) cache line to be sure that ITS sees
> flush means clean+invalidate, which is what you drop, so please drop
> "flush" word.
>
> > command written into the memory.
> >
> > Signed-off-by: Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>
> > Signed-off-by: Daisuke Nishimura <nishimura@xxxxxxxxxxxxx>
> With that:
> Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
>
> ~Michal
>
|