[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/arm: its: only clean cache when sending ITS command
- To: Daisuke Nishimura <nishimura@xxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: "Orzel, Michal" <michal.orzel@xxxxxxx>
- Date: Tue, 17 Nov 2026 08:45:27 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=valinux.co.jp smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=A5c8oHcbdWhdUwIYMWGAk/8YQI1wJ9evgJmA0myjSqo=; b=EayhpTu42wOxyck7kP4ztyCQlfcRfUJn0Nq7Y6uV4XfesOjPRlONYq4Yt53iybj+1yQBtMPHcLjeT8k/w2b/hv1NyrlDh0GWJuHtt0Cm8dPqzMlZU28IwLe4A5TB6cyYtIu7ep1/PeQccHTWmxSv4Iz54OQLtjCzhIB1L+zCCLYvg9RU+ElWwixjfPRhaTTDv6Dc9i18b0StpCuoULtNmcRYFIH2JaY4qqR5fZdDeg30enH5VmFdH994v/IXSt1z8WQ+T5xL8e6wzP+gFHYXUphN63NmZ4IsSCEg/ARYFNc21kVCqv63gkEnmoGQneWeFpU3oy2Bpm1G7KMg1BTFIA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Wfz6tZBxBnjklvFh/j6tfIUSfNwnN/+jcsFCoB0Smp/jarXh/rY4qHChGqh8Fk68Wxp1dq9j1q6t5liiU4d16iKISD71fXBF5S6zO+XoC5qopR24QBn6tI3SRWx90T7bH+dkXvD8wMbmqBTt0Wysarfsiwv6Y+8U2YIsQWfcSC5tW9U6uZfNTSQevL6czJKboxva77v92w1fVcXl11uJDzfjMEch8g6F1l8d/ILWdVWevgu4ag7vHGvKkbA06CcoKWR5b+28Fj+e4NYuUhnjm37JH/Ai5OTi4T4YJn/55KTpXqppZPnCrptrIxET5SNZjc4b3boqp4nP4TesdjwRZQ==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Cc: Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>
- Delivery-date: Tue, 17 Nov 2026 07:45:42 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 17-Nov-26 04:32, Daisuke Nishimura wrote:
> From: Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>
>
> There is no need to invalidate cache entry because we just wrote that
> memory. So it is guaranteed that cache entry is valid.
I don't think this is a good rationale. What makes invalidation not
needed here is that the CPU is the only writer and the ITS the only
reader of this buffer, so the cached data cannot be stale. Invalidation
would be needed if a device wrote a buffer that the CPU later reads.
>
> But we need to clean (flush) cache line to be sure that ITS sees
flush means clean+invalidate, which is what you drop, so please drop "flush"
word.
> command written into the memory.
>
> Signed-off-by: Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>
> Signed-off-by: Daisuke Nishimura <nishimura@xxxxxxxxxxxxx>
With that:
Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
~Michal
|