[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2] xen/arm: its: only clean cache when sending ITS command
- To: xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Daisuke Nishimura <nishimura@xxxxxxxxxxxxx>
- Date: Wed, 18 Nov 2026 11:15:29 +0900
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ovnKkosMrB1fv38MrxAM4+qRimsuEdr04aS/41OUSjE=; b=FmMjZKY5D0eZJf/otlbBIv+SM93Wbj5fTk6NZflhCdqg0GXQn/l03ptHqbjSTyH22YIfLSrODBKysJ3f+/iXEfVoDqKjdgAu/frHRq35i2piFd/8WbvHQiPXZSqnGy/w+1rtR5g+ky0Uy6fG1otWRa0RamK0GJ+ha4ipHebRZnfs/alE8WPoUHHT/qfpKVl6yvPniDgitH//eLjl5z3wgjXRcdIVWbsfi/Zb9XRkiEOkKo/7/yPqqrRKbLxHcLfoSXPgZVTVm8GlLeTMKWoGla3uHTeHPIG4Y9GAT2ka3AZe770RgjQjkQe6PacyVRBUviC70hiXB7ud3MO/vNR7Aw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jMA1O1ljqLgZRCQPD8sDw4NKCKiBiLhQvayjSw52DfvF/OloodOHNcDCGkOL3SUMn846IE+FBjfjUIkIHII2bloS7lDry7hryt+Lg64h2aYitnmIYByAYaIjoSm5bVge618zasgv6ls3hSbmE8CiB7skeawAU+eNKnIu9Zkt3FgciByS8C6JT2Dtn8xWM5S2EO7uD/bHxUWYrloOj/I2IcpFaflJy7kuadXa39OWPO6GEAVPsnYXrZZboQGRof8KRu4LOydmGHBjQoFj8RW4MTTwhEblz1wza0xBvToSNu6MEJrfFXnCpzpKD/osAVGjrgGwd3GwrCJf/o8v8SuRzQ==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=valinux.co.jp header.i="@valinux.co.jp" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Authentication-results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp;
- Cc: Daisuke Nishimura <nishimura@xxxxxxxxxxxxx>, Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Wed, 18 Nov 2026 02:16:08 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
From: Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>
There is no need to invalidate the cache entry because the CPU is the only
writer and the ITS is the only reader of this buffer, so it is guaranteed
that the cached data cannot be stale.
However, we still need to clean the cache line to be sure that ITS sees
the command written into memory.
Signed-off-by: Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>
Signed-off-by: Daisuke Nishimura <nishimura@xxxxxxxxxxxxx>
Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
---
(cherry picked from commit fe7142bca56b5c8c8109f581444f89ae09b7544f xen-troops)
v2: Update the commit message.
---
xen/arch/arm/gic-v3-its.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/xen/arch/arm/gic-v3-its.c b/xen/arch/arm/gic-v3-its.c
index 325835b0ad..dc44666233 100644
--- a/xen/arch/arm/gic-v3-its.c
+++ b/xen/arch/arm/gic-v3-its.c
@@ -207,8 +207,7 @@ static int its_send_command(struct host_its *hw_its, const
void *its_cmd)
memcpy(hw_its->cmd_buf + writep, its_cmd, ITS_CMD_SIZE);
if ( hw_its->flags & HOST_ITS_FLUSH_CMD_QUEUE )
- clean_and_invalidate_dcache_va_range(hw_its->cmd_buf + writep,
- ITS_CMD_SIZE);
+ clean_dcache_va_range(hw_its->cmd_buf + writep, ITS_CMD_SIZE);
else
dsb(ishst);
--
2.43.0
|