[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] x86/vlapic: accept a logical destination of all ones as a broadcast


  • To: Stefano Stabellini <stefano.stabellini@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Tue, 17 Nov 2026 12:43:04 +0100
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID"
  • Autocrypt: addr=jbeulich@xxxxxxxx; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger@xxxxxxxxxxxxxx>, Teddy Astie <teddy.astie@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Tue, 17 Nov 2026 11:43:18 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 17.11.2026 03:05, Stefano Stabellini wrote:
> In logical destination mode, a destination of all ones is a broadcast
> accepted by every local APIC: 0xff in xAPIC mode, in both the flat and
> the cluster model (AMD APM vol. 2, 16.6.1), and 0xffffffff in x2APIC
> mode (AMD APM vol. 2 Rev 3.39, 16.14).

While revision number plus section number properly disambiguate things,
this still isn't very practical: Readers may not have that revision to
hand. Therefore we (much) prefer section titles; amending them by rev+
secno is okay.

> vlapic_match_logical_addr() treated these as ordinary logical
> destinations, so a broadcast reached only the vLAPICs whose logical ID
> happened to match it. In particular, a vLAPIC whose logical ID is 0
> received no logical broadcast at all.
> 
> Match the broadcast in each model. A destination format register naming
> neither model still matches nothing.

Along the lines of what you say here, why not a simpler change in the
sole caller of vlapic_match_logical_addr(), with this as a result (sans
comment for now):

    case APIC_DEST_NOSHORT:
        if ( dest == _VLAPIC_ID(target, 0xffffffffU) )
            return true;
        if ( dest_mode )
            return vlapic_match_logical_addr(target, dest);
        return dest == VLAPIC_ID(target);

? Otherwise I'd be inclined to ask for simplification of ...

> --- a/xen/arch/x86/hvm/vlapic.c
> +++ b/xen/arch/x86/hvm/vlapic.c
> @@ -209,9 +209,16 @@ static bool vlapic_match_logical_addr(const struct 
> vlapic *vlapic, uint32_t mda)
>      bool result = false;
>      uint32_t logical_id = vlapic_get_reg(vlapic, APIC_LDR);
>  
> +    /*
> +     * A destination of all ones is a broadcast in logical destination mode
> +     * too, accepted by every local APIC: 0xffffffff in x2APIC mode (AMD APM
> +     * vol. 2 Rev 3.39, 16.14), and 0xff in both the flat and the cluster
> +     * model in xAPIC mode (AMD APM vol. 2, 16.6.1).
> +     */
>      if ( vlapic_x2apic_mode(vlapic) )
> -        return ((logical_id >> 16) == (mda >> 16)) &&
> -               (uint16_t)(logical_id & mda);
> +        return (mda == 0xffffffffU) ||
> +               (((logical_id >> 16) == (mda >> 16)) &&

... this and ...

> +                (uint16_t)(logical_id & mda));
>  
>      logical_id = GET_xAPIC_LOGICAL_ID(logical_id);
>      mda = (uint8_t)mda;
> @@ -219,11 +226,13 @@ static bool vlapic_match_logical_addr(const struct 
> vlapic *vlapic, uint32_t mda)
>      switch ( vlapic_get_reg(vlapic, APIC_DFR) )
>      {
>      case APIC_DFR_FLAT:
> -        if ( logical_id & mda )
> +        if ( (mda == 0xff) || (logical_id & mda) )
>              result = true;
>          break;
>      case APIC_DFR_CLUSTER:
> -        if ( ((logical_id >> 4) == (mda >> 0x4)) && (logical_id & mda & 0xf) 
> )
> +        if ( (mda == 0xff) ||
> +             (((logical_id >> 4) == (mda >> 0x4)) &&

... this while touching this code anyway.

Jan

> +              (logical_id & mda & 0xf)) )
>              result = true;
>          break;
>      default:




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.