[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/4] x86/IRQ: use less heavy locking in free_domain_pirqs()



On Tue, Nov 17, 2026 at 11:38:29AM +0100, Jan Beulich wrote:
> On 17.11.2026 11:31, Roger Pau Monné wrote:
> > On Thu, Oct 29, 2026 at 03:24:13PM +0100, Jan Beulich wrote:
> >> Holding the domain's PCI lock (alongside its event lock) is sufficient
> >> around unmap_domain_pirq().
> >>
> >> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> > 
> > Acked-by: Roger Pau Monné <roger@xxxxxxxxxxxxxx>
> 
> Thanks, but: Considering your reply to patch 1, did you forget to make this
> conditional upon the same prereq change that you outline there?

Strictly speaking this function is only called from
arch_domain_destroy(), which is done after PCI devices are deassigned
and MSIs are torn down.  In this context unmap_domain_pirq() is only
caled against GSIs.  But yes, for correctness (and to avoid confusion)
I should have tied it to the same request as patch 1.

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.