[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] x86/vlapic: accept a logical destination of all ones as a broadcast


  • To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Stefano Stabellini <stefano.stabellini@xxxxxxx>
  • Date: Mon, 16 Nov 2026 18:05:59 -0800
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XbbrLALmmSPXX4WJfkUBP8ueMSLKNJYXpESr54/ykt0=; b=plVtXhYCVO3sKS3kvaxsYApgpsC77HcIhKTT+RHLNVDs1eSXtFxPP0fwHAgYRpY18amwN8LgOBaPETf3HbWXf1dbRGowps+xHE4fIPPOLPDYZlG6BT0Ceex69dvuv0gicbodLZ42ZB6yUrDek5Vgg3ztN2QeupA8u/+sJLM88pEgMh2dfjJSlOzY4gYnppDMVkb6VY9wFJf/7+nH2/FoVM8ftoDvxvos0kE/H1gst4KWDUakS3dv/6E1w0fhZemqw9ge7eMONzzlq9iqGIP6bUhzSonp9XK5Ank5RUYWFIk82/PlUN+dB3FTHIuxXxa2jx3L1PDXINXLogvBN4j1Gw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=p2GyoOLMI8jmcFASNx7RZPITZKX5urlIkXx4EDJYlE91YlMjgoHbMsRXXraU8aMZ/PYH+ptyQLeaiufygeu/K9/3tqcWE6YFEkCABH1QZFiMe+rfdaW3AuxGftp94HOJGb657rhneXU5ZDJY7X5Xp0Jip5G+kOdY0MwuzSemizeN+oXlf9M9YefEEFI05ecZUaZHbGWQKf64ccbQCcxOBVJ1MihZZpL/6s7r35fWOY+N8E3qqR4IBcHrM9peV8ylrwxlNCzvHHHuKNs31k6i8h766bDpgSQ0SXs51eCPeevBgXg8m3DBxb9U94LAxVaw2t5pQDmgTUMONFPJmXwbKA==
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
  • Cc: <stefano.stabellini@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, "Andrew Cooper" <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger@xxxxxxxxxxxxxx>, Teddy Astie <teddy.astie@xxxxxxxxxx>
  • Delivery-date: Tue, 17 Nov 2026 02:06:36 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

In logical destination mode, a destination of all ones is a broadcast
accepted by every local APIC: 0xff in xAPIC mode, in both the flat and
the cluster model (AMD APM vol. 2, 16.6.1), and 0xffffffff in x2APIC
mode (AMD APM vol. 2 Rev 3.39, 16.14).

vlapic_match_logical_addr() treated these as ordinary logical
destinations, so a broadcast reached only the vLAPICs whose logical ID
happened to match it. In particular, a vLAPIC whose logical ID is 0
received no logical broadcast at all.

Match the broadcast in each model. A destination format register naming
neither model still matches nothing.

Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxx>
---
CC: Jan Beulich <jbeulich@xxxxxxxx>
CC: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
CC: Roger Pau Monné <roger@xxxxxxxxxxxxxx>
CC: Teddy Astie <teddy.astie@xxxxxxxxxx>

 xen/arch/x86/hvm/vlapic.c | 17 +++++++++++++----
 1 file changed, 13 insertions(+), 4 deletions(-)

diff --git a/xen/arch/x86/hvm/vlapic.c b/xen/arch/x86/hvm/vlapic.c
index 6698779e22..ed745a810c 100644
--- a/xen/arch/x86/hvm/vlapic.c
+++ b/xen/arch/x86/hvm/vlapic.c
@@ -209,9 +209,16 @@ static bool vlapic_match_logical_addr(const struct vlapic 
*vlapic, uint32_t mda)
     bool result = false;
     uint32_t logical_id = vlapic_get_reg(vlapic, APIC_LDR);
 
+    /*
+     * A destination of all ones is a broadcast in logical destination mode
+     * too, accepted by every local APIC: 0xffffffff in x2APIC mode (AMD APM
+     * vol. 2 Rev 3.39, 16.14), and 0xff in both the flat and the cluster
+     * model in xAPIC mode (AMD APM vol. 2, 16.6.1).
+     */
     if ( vlapic_x2apic_mode(vlapic) )
-        return ((logical_id >> 16) == (mda >> 16)) &&
-               (uint16_t)(logical_id & mda);
+        return (mda == 0xffffffffU) ||
+               (((logical_id >> 16) == (mda >> 16)) &&
+                (uint16_t)(logical_id & mda));
 
     logical_id = GET_xAPIC_LOGICAL_ID(logical_id);
     mda = (uint8_t)mda;
@@ -219,11 +226,13 @@ static bool vlapic_match_logical_addr(const struct vlapic 
*vlapic, uint32_t mda)
     switch ( vlapic_get_reg(vlapic, APIC_DFR) )
     {
     case APIC_DFR_FLAT:
-        if ( logical_id & mda )
+        if ( (mda == 0xff) || (logical_id & mda) )
             result = true;
         break;
     case APIC_DFR_CLUSTER:
-        if ( ((logical_id >> 4) == (mda >> 0x4)) && (logical_id & mda & 0xf) )
+        if ( (mda == 0xff) ||
+             (((logical_id >> 4) == (mda >> 0x4)) &&
+              (logical_id & mda & 0xf)) )
             result = true;
         break;
     default:
-- 
2.47.3




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.