[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] xen/arm: its: only clean cache when sending ITS command


  • To: xen-devel@xxxxxxxxxxxxxxxxxxxx
  • From: Daisuke Nishimura <nishimura@xxxxxxxxxxxxx>
  • Date: Tue, 17 Nov 2026 11:45:18 +0900
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gUkaIR8pKv4my8MY7xVlAEOZZmOyCA9V00WbhJSGHSU=; b=TPwppj0Fk8TCw8xnWOwas3QhPEvPgddA/lv+y/mBVPgTuxJ10wM1DMkwjS/vMeXT1o/tB3g5lJJu1DNG9p5PLqBFROJd18E9cNhkb0GyXEgHn6Jyo/+Rh4CAx9bgbMvjsQ4PfEz+jHWXjpmmzbhugaD7iPGwKkJLJW3aOnynHKBjStA6jzkVDLCZK6QQIUk2zq+Wd69cCnY6Iri96NtjbpcgWYWassbuo1b/XKcHAysTYxFCZGdSg0ajGp60HMjlkMJI3ZUV/4nvLaGvXbBh2s4u93p6fwDD2ZWhxXJ8U3gsUM2HcM1ZGZI3XgnkC3F6YuOv6s/iLd2Kzu1Ojb5gQw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=n3G5HWeydnOWALEUULzKoRP5/PydsqL0lyDjruif/IjK1MlzdJlZ+v4KeOngim3Me2U0DEZDV+yugAShy3q2F56j2gkxf34BRJFLVxqdeFDD2bQHB6Wrdg1+t7GOhNmJhJcseuWpyEGlPwLPed+9IyDOIOHBpK2CzBPVEhMIxRVu3eQwvYH7AEmtAx0rVWbbf9HvfdZiQcWzRmFxu63YWNqFboRdfTBUYG3IZLpOfR6UcI1wDYRgy4VVRSUGzi8VNgyIgguJh5wfpcWfkjmXN5140LGj748kB2dY/wB0dLfbuRQM/Mu3autCi4kZOc4HEScjHzheqvwaS6iO8Z0t9Q==
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=valinux.co.jp header.i="@valinux.co.jp" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
  • Authentication-results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp;
  • Cc: Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>, Daisuke Nishimura <nishimura@xxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Tue, 17 Nov 2026 02:45:48 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

From: Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>

From: Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>

There is no need to invalidate cache entry because we just wrote that
memory. So it is guaranteed that cache entry is valid.

But we need to clean (flush) cache line to be sure that ITS sees
command written into the memory.

Signed-off-by: Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>
Signed-off-by: Daisuke Nishimura <nishimura@xxxxxxxxxxxxx>
---
(cherry picked from commit fe7142bca56b5c8c8109f581444f89ae09b7544f xen-troops)
---
 xen/arch/arm/gic-v3-its.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/xen/arch/arm/gic-v3-its.c b/xen/arch/arm/gic-v3-its.c
index 325835b0ad..dc44666233 100644
--- a/xen/arch/arm/gic-v3-its.c
+++ b/xen/arch/arm/gic-v3-its.c
@@ -207,8 +207,7 @@ static int its_send_command(struct host_its *hw_its, const 
void *its_cmd)
 
     memcpy(hw_its->cmd_buf + writep, its_cmd, ITS_CMD_SIZE);
     if ( hw_its->flags & HOST_ITS_FLUSH_CMD_QUEUE )
-        clean_and_invalidate_dcache_va_range(hw_its->cmd_buf + writep,
-                                             ITS_CMD_SIZE);
+        clean_dcache_va_range(hw_its->cmd_buf + writep, ITS_CMD_SIZE);
     else
         dsb(ishst);
 
-- 
2.43.0




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.