[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] xen/arm: its: only clean cache when sending ITS command


  • To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Daisuke Nishimura <nishimura@xxxxxxxxxxxxx>
  • Date: Tue, 17 Nov 2026 12:17:12 +0900
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8zlkmLdY3M3bWlaq1QszMq7fXTtpTXrxqGZZbIGJ7Uo=; b=Pdml0BbmWO+38jDu463d9YU0EyKj48ejTorTNiBQH8TqCoP6WaeefnJ2b+DwEr4xGllo3ldLuNbhCSObV0OfN+JUOwWIoFQCOCmnHrx6nZGmZoN22SPbEkocN1tT2tbNNjjp98mLBd9QJJhFPQbCPmXvrLoExzVwDXZ5LXq3IxGfEtaOK+NQtgBzvnki4/e+R/kJyzKQqWBCcciPkCP64RWRbO48YSYR6xRtpvCd64Op0v+tvJXCzL8kDxV04LeZheEZkegiGihTt3wRMZp+9ET4Z/ctwOpMrbiYqYGswxi48E9f3LXm7bIDBX0IJuBE2vv6fvQSQll1C/gymIdNCA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=X7NHVOaO9rNS4YpBEskSzbi7y5e2ZOSc6rpQcfbVr5BKGV25WHBCz1lcrfe6dRK1NwaRt9ER5YocOjN8Wx4QmPZr6ayM0ve0HNwKxJmDpTTRmSru8S0nCNiWN9pF0Isr8rh82+0lpppzQUVagN1mL9zWOMWCAC/3cqo127ybeg6lEn5k3k/+G8CJ5PQje+oVqHxx55FIYGBWYHNTMtQgwaRmQYL5j4OG+fyi6IuxdFW97YFu+YGVdUflFpgtPwC5dXQyEydK1dVvxNlsIdLGuMNapD/x1wJFlYj2YPWy8uR17AqOxQOR7fQSRvWiXJInck9igg5vzwpPPWtYfFLGCQ==
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=valinux.co.jp header.i="@valinux.co.jp" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
  • Authentication-results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp;
  • Cc: Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>
  • Delivery-date: Tue, 17 Nov 2026 03:17:39 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

I'm sorry that the 'From:' lines are duplicate.
I will resend a correct patch later.

On Tue, 17 Nov 2026 11:45:18 +0900
Daisuke Nishimura <nishimura@xxxxxxxxxxxxx> wrote:

> From: Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>
> 
> From: Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>
> 
> There is no need to invalidate cache entry because we just wrote that
> memory. So it is guaranteed that cache entry is valid.
> 
> But we need to clean (flush) cache line to be sure that ITS sees
> command written into the memory.
> 
> Signed-off-by: Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>
> Signed-off-by: Daisuke Nishimura <nishimura@xxxxxxxxxxxxx>
> ---
> (cherry picked from commit fe7142bca56b5c8c8109f581444f89ae09b7544f
> xen-troops) ---
>  xen/arch/arm/gic-v3-its.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/xen/arch/arm/gic-v3-its.c b/xen/arch/arm/gic-v3-its.c
> index 325835b0ad..dc44666233 100644
> --- a/xen/arch/arm/gic-v3-its.c
> +++ b/xen/arch/arm/gic-v3-its.c
> @@ -207,8 +207,7 @@ static int its_send_command(struct host_its
> *hw_its, const void *its_cmd) 
>      memcpy(hw_its->cmd_buf + writep, its_cmd, ITS_CMD_SIZE);
>      if ( hw_its->flags & HOST_ITS_FLUSH_CMD_QUEUE )
> -        clean_and_invalidate_dcache_va_range(hw_its->cmd_buf +
> writep,
> -                                             ITS_CMD_SIZE);
> +        clean_dcache_va_range(hw_its->cmd_buf + writep,
> ITS_CMD_SIZE); else
>          dsb(ishst);
>  




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.