Re: [PATCH 7/8] hw/9pfs: annotate V9fsTransport callbacks as coroutine_fn

[Marc-André Lureau <marcandre.lureau@xxxxxxxxxx>]

Hi

On Tue, Jul 21, 2026 at 12:38 PM Christian Schoenebeck
<qemu_oss@xxxxxxxxxxxxx> wrote:
>
> On Tuesday, 21 July 2026 10:25:34 CEST Philippe Mathieu-Daudé wrote:
> > On 21/7/26 10:06, Marc-André Lureau wrote:
> > > Hi
> > >
> > > On Tue, Jul 21, 2026 at 11:58 AM Marc-André Lureau
> > >
> > > <marcandre.lureau@xxxxxxxxxx> wrote:
> [...]
> > >> most of them are "return-type co_annotation fn(..)"
> > >> we even have scripts/block-coroutine-wrapper.py that relies and
> > >> produce this order..
> > >> a bit late to change the style imho...
> > >>
> > >> At least, let's not make this a requirement for this series, please
> >
> > Not a requirement on my side, but if we had to pick a style,
> > I'd vote for "attribute before return type".
>
> Yep, because that's a) the most compiler-friendly option (all compilers allow
> it, including MSC) and b) it's the most diff-noise friendly solution (can be
> prepended on its own line without touching any of the existing line(s) at
> all).
>

ok, what should I do? Send a preliminary patch to fix all annotation
positions? or just change the position in this patch or series?