[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 7/8] hw/9pfs: annotate V9fsTransport callbacks as coroutine_fn
- To: Marc-André Lureau <marcandre.lureau@xxxxxxxxxx>, qemu-devel@xxxxxxxxxx, Philippe Mathieu-Daudé <philmd@xxxxxxxxxxxxxxxx>
- From: Christian Schoenebeck <qemu_oss@xxxxxxxxxxxxx>
- Date: Tue, 21 Jul 2026 10:37:39 +0200
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=kylie header.d=crudebyte.com header.i="@crudebyte.com" header.h="Content-Type:Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From"
- Cc: Markus Armbruster <armbru@xxxxxxxxxx>, Peter Xu <peterx@xxxxxxxxxx>, Fabiano Rosas <farosas@xxxxxxx>, Daniel P. Berrangé <berrange@xxxxxxxxxx>, John Snow <jsnow@xxxxxxxxxx>, Vladimir Sementsov-Ogievskiy <vsementsov@xxxxxxxxxxxxxx>, Kevin Wolf <kwolf@xxxxxxxxxx>, Hanna Reitz <hreitz@xxxxxxxxxx>, qemu-block@xxxxxxxxxx, Stefan Hajnoczi <stefanha@xxxxxxxxxx>, Fam Zheng <fam@xxxxxxxxxx>, "Denis V. Lunev" <den@xxxxxxxxxx>, Greg Kurz <groug@xxxxxxxx>, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Anthony PERARD <anthony@xxxxxxxxxxxxxx>, "Edgar E. Iglesias" <edgar.iglesias@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Li Zhijian <lizhijian@xxxxxxxxxxx>
- Delivery-date: Tue, 21 Jul 2026 08:37:57 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tuesday, 21 July 2026 10:25:34 CEST Philippe Mathieu-Daudé wrote:
> On 21/7/26 10:06, Marc-André Lureau wrote:
> > Hi
> >
> > On Tue, Jul 21, 2026 at 11:58 AM Marc-André Lureau
> >
> > <marcandre.lureau@xxxxxxxxxx> wrote:
[...]
> >> most of them are "return-type co_annotation fn(..)"
> >> we even have scripts/block-coroutine-wrapper.py that relies and
> >> produce this order..
> >> a bit late to change the style imho...
> >>
> >> At least, let's not make this a requirement for this series, please
>
> Not a requirement on my side, but if we had to pick a style,
> I'd vote for "attribute before return type".
Yep, because that's a) the most compiler-friendly option (all compilers allow
it, including MSC) and b) it's the most diff-noise friendly solution (can be
prepended on its own line without touching any of the existing line(s) at
all).
/Christian
|
