[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 0/2] xen/common: llc-coloring parser fixes
- To: Mykola Kvach <xakep.amatop@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: "Orzel, Michal" <michal.orzel@xxxxxxx>
- Date: Mon, 25 May 2026 12:06:01 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=gmail.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PC8AmsdOJav2nT3TfPwky1vpKFPoayb1oxfx5g0rKyk=; b=X3weiGdG+620YnbYM0Kstr7EmOJ6lbuSOrGEc9ZGmxuqsZKU1oLLChnbC3XUeOVIW9PyMCC72tzfkaQKI+izeJ+XtjNfpxiha/RTTHxDy5QjCbSlXNj8YHN1vZsWkNo+JqOC/xHKK7noOJ95mP/S2dkAdchEfox4DM8RjMVPWcpe5r44U3sYgdzVzyEUqjegoOTiaaV6H1Wq69zlMYdmddws9E0gLUdSrd5+WREQKtWrbgIvcEwTg/TTBWxZYX6A3Vd8/6ZW9cXZmJt/sLQsHCqU0Mxikzc4BVS4ZUSqzwoqDn5NR4uuU0zGi4/ONjwUEFZy/KGTF768eFM0lETK9w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=mkXjson8tSXoLJZNIYuLApbMci6RsfLZqO3BE+U41dLgZJSQP1fgw/4mgKHcTivNZ/c7ytCCP5QoQMCIuNqGhYv/7ZUp1hQVyRu6sG905+7TPwJS3FcSdlnbGsiChCI7GeK844qUuwp12l6rc2C3Td8jrU/TiQoJOLJS742XRZMTFzLYBAraS8CuUIIMrCzXRm8x9IH7sYuUv+nG+iuuHZeKYh6smP6JBdicbWQkWUFHrD61GRkOcs7gpyecrUrDzCa/4SfkJxC9RRwd5a5JLmFzEQHIAXRonOHIP8lqug+V7bXE96uOn/9NzXHislJCRhARIjS2WaT+XG1Gj+60UA==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Cc: Carlo Nonato <carlo.nonato@xxxxxxxxxxxxxxx>, Marco Solieri <marco.solieri@xxxxxxxxxxxxxxx>, Luca Miccio <luca.miccio@xxxxxxx>, "Mykola Kvach" <mykola_kvach@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "Oleksii Kurochko" <oleksii.kurochko@xxxxxxxxx>
- Delivery-date: Mon, 25 May 2026 10:06:18 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
CC: Oleksii
@Oleksii, can we ask for your release ack for this series?
~Michal
On 21-May-26 20:41, Mykola Kvach wrote:
> From: Mykola Kvach <mykola_kvach@xxxxxxxx>
>
> Hi all,
>
> This small series fixes two issues in parse_color_config().
>
> The first patch makes parse failures leave the caller-visible color count
> at zero. This prevents a rejected command-line value from leaving a
> partially parsed configuration behind for later init paths to consume.
>
> The second patch rejects empty color tokens. Previously, delimiters in
> places where a color value was expected could be interpreted as color 0,
> because simple_strtoul() returns zero without advancing the input pointer.
> The patch checks that each parsed color value consumed input. It also
> fixes the DT color parsing error message by adding the missing newline
> and including the domain ID.
>
> Changes in v2:
> - Clarify the first commit message.
> - Include the domain ID in the DT color parsing error message.
> - Add Reviewed-by tags.
>
> Mykola Kvach (2):
> xen/common: llc-coloring: clear color count on parse failure
> xen/common: llc-coloring: reject empty color tokens
>
> xen/common/llc-coloring.c | 24 +++++++++++++++++++-----
> 1 file changed, 19 insertions(+), 5 deletions(-)
>
|
