[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/2] xen/common: llc-coloring: reject empty color tokens
- To: Mykola Kvach <xakep.amatop@xxxxxxxxx>
- From: dmukhin@xxxxxxxx
- Date: Thu, 21 May 2026 14:33:30 -0700
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 148.163.138.245) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=ford.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=ford.com; dkim=pass (signature was verified) header.d=saarlouis.ford.com; dkim=pass (signature was verified) header.d=ford.com; arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=syniypRRsUpjlhhY1OgRFFdGbkGN0+6TBd6U04YUH58=; b=ESiT56EXagy+YXBkESCdrrBd7UpHk7ohClNaHpAMUuzTF5DpzrZQ4N6/7mhTNah25wKCSp4Zodn0ZI8XCkV0S9fUHkMQhTgBy0UFN45CIG+AAHxWCmzP0lh877+A0l/BMELWM2AshNP80LrbKMYwglP6p2TqbYpdGGEausAXRp2Y1/Kqs1e+sKGEBm1efjRcEO1XJUafqdBKzlPbRt6NVqMokJOQDfec1sO83xzGGFtcmUJIn4t2yb9goID8R0a6a01RTKaeNRlt+pkaKFz4BlaCHt2hLO4y0onySRklH2m2wmP4ETe4UbAwNnrSanMY9pOaWmjweEYPR1VCIkXhVw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=OVYtuYr5iuH49XtMI4bTMIn9N3IXehvE+LHjEsUvox1CPW3+dyIlVJqQCBf1vU8mfZN4yL3S2bfOsqRewvTKR3vsh11zxWt7zjn/iGiUQDz8A10yjl1q2I8y4vR91pbkBah4hCXt8SWfny7fhw0iYe1p4VDB6zHTtF2kZWffMy5kRUN6lz/5j1S14wekItotpC+lrW/IKnCxxiRzssp1cpVLAYz+yY/FYsgX8nRe9pBQjeBcIGt1MXXVJSQjZsnMc8DpbtG5+eUROElksl0d6ZGPuiDsUvQUSI+iqnPilAcuqso3KPe2lUnm+GPRlJdileV88PzG7lr1s7J6mPL40A==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=ppford header.d=ford.com header.i="@ford.com" header.h="Cc:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=selector2-azureford-onmicrosoft-com header.d=azureford.onmicrosoft.com header.i="@azureford.onmicrosoft.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"; dkim=pass header.s=ppserprodsaar header.d=saarlouis.ford.com header.i="@saarlouis.ford.com" header.h="Cc:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=ppfserpocford header.d=ford.com header.i="@ford.com" header.h="Cc:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Carlo Nonato <carlo.nonato@xxxxxxxxxxxxxxx>, Marco Solieri <marco.solieri@xxxxxxxxxxxxxxx>, Luca Miccio <luca.miccio@xxxxxxx>, Mykola Kvach <mykola_kvach@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- Delivery-date: Thu, 21 May 2026 21:34:01 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Pser-m365-app: SER-APP
On Thu, May 21, 2026 at 09:41:22PM +0300, Mykola Kvach wrote:
> From: Mykola Kvach <mykola_kvach@xxxxxxxx>
>
> parse_color_config() currently accepts delimiters where a color value
> is expected because simple_strtoul() returns zero without advancing the
> input pointer. This makes strings such as ",2-6", "-10,19-20" or
> "1,,2" look as if an empty value was color 0.
>
> Also fix the DT color parsing error message by adding the missing
> newline and including the domain ID, matching the style of the color
> validation error below.
>
> Fixes: 6cdea3444eaf ("xen/arm: add Dom0 cache coloring support")
> Signed-off-by: Mykola Kvach <mykola_kvach@xxxxxxxx>
> Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
Looks good, thanks!
Reviewed-by: Denis Mukhin <dmukhin@xxxxxxxx>
|
