[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/arm: gic-v3: Preserve ARE_NS when disabling the distributor
- To: Mykola Kvach <xakep.amatop@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: "Orzel, Michal" <michal.orzel@xxxxxxx>
- Date: Mon, 25 May 2026 12:18:31 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=gmail.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Y1c9lQ3wZ/NaJa5sV0AexiH1fCfTRpsF7NxGI19Zg14=; b=V+05kZtYeCY/jKSINUW7cx7mk23Rf5BoX5/wvEFK532Pfrb3JRN97F3ACEBNwZZG6VyAqXYJWROiB9MxNUqoTyuCVhicHN9BBILPJhvTm1PLeB60UYsOGtTR+YVWk2YhuFl3wOwY8W8D+jk5UIQ+qkVhswacZTi1QX9LrT/SCL05rOiMj4gcYuY559RT5wuRyM5MK4YksjppLNSU5cv3yHsy9A4hmBx5SFxTmY6inUarflcZnxKoLkpFpIABTwj7RZSOoTwDanXFmfda2bviGW9SN5IjmNKddG9BGMKggWkDcy8nF3U+QA1JmjKgSZLrmKPCTza3ycWVBU4CYbnfww==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=iMWco5inqDgGGF7zgFQjIViUK5DdsaYU/acGa4LCzjxogZ5ib0DooiqK4xOR1wM7muZbAwrxSXP6EtAIRqK8FJNgoIdRW72cwSVC4/kGrlsBywpJXmeBiGfr/q7jXsn7hZF/6+Y7HjJIEvCH7iB9tMgWhgVPPSGwfy75HPV+VRzY13NyeMaNYNJ/D17VUYvxMQZV1O3V2yZTD+N+0yMjmvZmrWAMkVM6tNlZETOMnEpiUbVOormkjK9/n8E8GawPq5/UA3TRPbsqbHum4zZC9s998mQHzzuQFZrjtvlKvOgaRnKptpCPYZR4Huy5LC+VYoiC9/fZIqTQcoSm0g8aMw==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Cc: Luca Fancellu <luca.fancellu@xxxxxxx>, Mykola Kvach <mykola_kvach@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "Julien Grall" <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
- Delivery-date: Mon, 25 May 2026 10:18:48 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 19-May-26 16:31, Mykola Kvach wrote:
> From: Mykola Kvach <mykola_kvach@xxxxxxxx>
>
> gicv3_dist_init() disables the distributor before reprogramming the
> global interrupt state. It used to do this by writing 0 to GICD_CTLR.
>
> On a system where firmware has already enabled Non-secure affinity
> routing, a zero write clears the Non-secure view's GICD_CTLR.ARE_NS bit.
> Arm IHI 0069H.b, section 2.3.3 ("Changing affinity routing enables"),
> states that changing GICD_CTLR.ARE_NS from 1 to 0 is UNPREDICTABLE. The
> GICD_CTLR register description in section 12.9.4 carries the same rule
> for the ARE_NS field.
>
> Preserve ARE_NS while clearing the group enable bits. If firmware left
> ARE_NS clear, the value written is still 0, preserving the existing
> initialization flow.
>
> Fixes: bc183a0235e0 ("xen/arm: Add support for GIC v3")
> Signed-off-by: Mykola Kvach <mykola_kvach@xxxxxxxx>
Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
@Oleksii, can we ask for a release ack here?
~Michal
|
