Re: [PATCH 6/6] xen/dt-overlay: attach resources for child nodes in overlay

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Wed, 15 Apr 2026, Luca Fancellu wrote:
> Hi Michal,
> 
> > On 15 Apr 2026, at 12:37, Michal Orzel <michal.orzel@xxxxxxx> wrote:
> > 
> > handle_attach_overlay_nodes() only calls handle_device() on the
> > top-level overlay nodes tracked in entry->nodes_address[].  Child nodes
> > that have their own reg, interrupts, or iommus properties are never
> > processed, so their IRQs are not routed, MMIO regions are not mapped,
> > and IOMMU setup is skipped.
> > 
> > Introduce handle_device_and_children() which recursively walks the
> > subtree rooted at each overlay node and calls handle_device() on every
> > descendant, ensuring all resources in the overlay are properly attached.
> > 
> > Note that the attach error path has a pre-existing bug: on partial
> > failure, the tracking rangesets are destroyed without first revoking the
> > IRQ/MMIO permissions and IOMMU assignments that were already granted by
> > the successful handle_device() calls.  Add a TODO comment to flag this.
> > 
> > Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
> > ---
> > 
> 
> Looks ok to me
> 
> Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>

Acked-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>