[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 6/6] xen/dt-overlay: attach resources for child nodes in overlay
- To: Michal Orzel <michal.orzel@xxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Wed, 15 Apr 2026 15:55:57 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=amd.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Tk7/cHl0rzOfWaoLWd/gpPXNecC2vp6Jp0xxxlMwimQ=; b=RFdtADAeZMDJQeiFOcMw0J2w4YaNqQ1v7/jrN8+uUo01KdqEBNIxYfemR5kT36B6BadwpZ/7euq6GItpiJJguZirbtyscMRz5LFlaKVHmVFEH5O/O8AVyurcAsgV7eIRGOvmKDdd8AEJxF264EVhi6oDzSnqQOOcx86kDiE0vCugF2QMII/sioaaOIlsm/au/dtFbd6CRgH7h073xP95LQZcLa9vjrJp3fcqbqg619rDkM2EAvw+GbGNHo+N35Dv8QjeM4ODcgBssVRrbaNGS45Dt4+mM/M9qm0/Kve4o1ydB2PpUAZo7rG/H0jiI3Sf1uWCib3BPsrFg3Qb3BJCpw==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Tk7/cHl0rzOfWaoLWd/gpPXNecC2vp6Jp0xxxlMwimQ=; b=DcrrVk5bjxE/A+NYIeC/KG26rOUGymlbYdPySNYGeSPtgzlOeg332ysJdE/fKPtZTGOyThc8ZPuCSVm1G2hihdJn3TIGHKpD74/fV8PRxbdYY+U6xbOhhe+ztfJOwHXDH0frinWq7PcOupM9l2ordjqCaiua8U1jwVG2+5WK+F2UCapZSzZrH3ey25sD0TDRnj2+zg63W7wJSJDaCVmG+omMD44FNSUhn4grUhtqtGkyT7Wut1+cOqkQLOU8tMvc20k92eY3EBBcDvmqCOgd2uLzy70dmsvZJ2CyfRtAMf1LdtbRssSAtSuxzLdaM9odld6HtnQpbJJES+xdAim4gQ==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=AYGZUILptsh0Gvz5JnsO0EFQ0rLkJDpL0tEceSOIivTLSkbxZ6ViGTC553iIUkdnwysMDVO/oMd/P+Lmgmol2FKTH4Ndql2fsKfUIyU4Tfki6pshr0OFW8cMGFUuY/FpQHzBwKdL6M5GndgcFQj9E5WDw1h7Wk9vLGoT82L80PxE1Rl5F+jO2WEf/dUq4j2B2jcG8S4rmAqbbgct52WPf7lHluNUtkdgsGLN/tcXtPOGdS1/OCM0Q0zJR/FkieLsW3xsLq8KxfZFuNnyMcf99T6ZqvSYXrrMEH9ICOM8KmR2rgMaHZbAVCHp59NEOuXR7qwDjzwAv5HVL/3ZxOXGhg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=pOKs2OBkkZBXMWjChgm+XymeKLZhbAotL3WY0qd5gaoMYAQbPzBGzuj2E4XHZ7H/6Qbfy/xR/anuJgUYUVtXrhqK96EKPSLRjS6mBykhpB7sHfLcEKZ3svibhgc038d2JkfmbA25QMn9j05QNeMoEfQNCy3iXgIPNZMPrgb1/MtGQ75TsuZUZfWVvTNmSESSMrTQXPdp2VdI9uMO42jiou4eadmlZWbEmxCa+m99oiUYJZVQyUb7F0yweN6qDMwr1m387DA1Gg+n0FYo2lyfF7tVAqK4U/BDsbFAdERvRsLjjHoyKamR1pOES4xuuTeBP0lUCs192Epc4IwZCScyDA==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=arm.com header.i="@arm.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"; dkim=pass header.s=selector1 header.d=arm.com header.i="@arm.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Delivery-date: Wed, 15 Apr 2026 15:57:20 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Thread-index: AQHczMxJagU60W5wKEqy3Z9xj7be5LXgRvWA
- Thread-topic: [PATCH 6/6] xen/dt-overlay: attach resources for child nodes in overlay
Hi Michal,
> On 15 Apr 2026, at 12:37, Michal Orzel <michal.orzel@xxxxxxx> wrote:
>
> handle_attach_overlay_nodes() only calls handle_device() on the
> top-level overlay nodes tracked in entry->nodes_address[]. Child nodes
> that have their own reg, interrupts, or iommus properties are never
> processed, so their IRQs are not routed, MMIO regions are not mapped,
> and IOMMU setup is skipped.
>
> Introduce handle_device_and_children() which recursively walks the
> subtree rooted at each overlay node and calls handle_device() on every
> descendant, ensuring all resources in the overlay are properly attached.
>
> Note that the attach error path has a pre-existing bug: on partial
> failure, the tracking rangesets are destroyed without first revoking the
> IRQ/MMIO permissions and IOMMU assignments that were already granted by
> the successful handle_device() calls. Add a TODO comment to flag this.
>
> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
> ---
>
Looks ok to me
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
Cheers,
Luca
|
