[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 0/6] dt-overlay: some fixes and improvements
- To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Michal Orzel <michal.orzel@xxxxxxx>
- Date: Wed, 15 Apr 2026 13:36:54 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/P1AkaFLYhWOON2UBch2rg76UUV/R3rJhXF5sFoZeyw=; b=paTeMkbAvrElntBkYpvNCXVZbn/qZkfeDkSOJN3/uaWNIM+UqxnUwDje3oxXgXMYcAILvjIW4Mnyq0PlhOO/6xB7yKxOQlYB1kRD5d0xUhByRQvZ9F64NWyvfCC7+gUSscI7GM5yYoAqMf5zP/4sPpRLofZENqpifKSazDVBTX2ntTRjuNqU42xL5s4dULt6IxTn47IQLsALpSTpFvUTCAFPUuG0fR5r7qTMKrC8NfVQPTVn1Sv9X4qkCP2H1xqNoAFyvneMbHW7i2kr0DD11KBnBXKi3sri2U3Oed/k+hHuWYiP3ECWIdoTiylmtVHxFEUgU95Pw/RofoQ3e1/fvg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=w+fOpr9kC2Blpa/vNJadYpwb/mlw1Hfhw3cFWmEJx27vdgLb9fvnAGwgqbRCsUpAgfPkq2cUQB/nTPSvhlLEEjCxNhUkxoxkXIxwPMqnu7R49rjzzvDhXGZQxxeytSWCkujGMUrVi23rRR3h7X4Es2ZLsBTL13/WitN6HdpYMzITNQxhj80R2OhWn2qAvlPbntDv9cca3UxTub8Zly6LD/8r3LfZ+6cbnWYe17cFPjaOkVl5yo6TvQ7FsMWM3zgv6TE01pGts/C/HHxYhhX7jz/sEZopg8ZTaqlwu+3FC3hk7T06xGwnlvceAteRz6D8YASYD1ucso71ieVk2c/jmA==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Cc: Michal Orzel <michal.orzel@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>
- Delivery-date: Wed, 15 Apr 2026 11:37:31 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
I don't like the state this feature is in right now. While the feature, even in
Linux is quite fragile, I investigated quite a lot of corner cases and many
issues are present due to the fact that we support a weird combination of
ADD/REMOVE + ATTACH without DETACH. Focusing on fixing issues and implementing
DETACH is not an easy task now. REMOVE handles things that should really be done
by DETACH. I think that the best move forward would be to strip the REMOVE
operation from the dt-overlay subsystem (I would preserve ABI). This would
eliminate the buggy, incomplete teardown code and leave a clean ADD+ATTACH
surface to later build DETACH and a proper REMOVE on top of. Thoughts?
The removal of REMOVE could be done in this release, not to carry on the buggy
code.
I tested this series with the AMD SW/HW stack.
Michal Orzel (6):
xen/dt-overlay: fix double-free of rangesets on attach failure
xen/dt-overlay: fix rangeset leak and dead code in domctl path
xen/dt-overlay: check overlay size before memcmp in tracker lookup
xen/dt-overlay: fix silent success in dt_overlay_remove_node
xen/dt-overlay: support phandle-based targeting in
overlay_get_nodes_info
xen/dt-overlay: attach resources for child nodes in overlay
xen/common/device-tree/dt-overlay.c | 120 ++++++++++++++++++++++++----
1 file changed, 105 insertions(+), 15 deletions(-)
--
2.43.0
|
