Re: [PATCH 4/6] xen/dt-overlay: fix silent success in dt_overlay_remove_node

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Wed, 15 Apr 2026, Luca Fancellu wrote:
> Hi Michal,
> 
> > On 15 Apr 2026, at 12:36, Michal Orzel <michal.orzel@xxxxxxx> wrote:
> > 
> > dt_overlay_remove_node() silently returns 0 when the target node is not
> > found in the parent's sibling list.  The loop simply exits without
> > matching and falls through to "return 0", making the caller believe the
> > node was successfully removed.
> > 
> > Return -ENODEV after the loop when no match is found, and change the
> > found-path from break to an explicit return 0 so the two outcomes are
> > distinct.
> > 
> > Fixes: 7e5c4a8b86f1 ("xen/arm: Implement device tree node removal 
> > functionalities")
> > Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
> > ---
> 
> Looks ok to me
> 
> Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>


Acked-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>