[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/6] xen/dt-overlay: fix silent success in dt_overlay_remove_node
- To: Michal Orzel <michal.orzel@xxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Wed, 15 Apr 2026 15:08:54 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=amd.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JwNicM0MXbmAJx8wdyghKv0O4TJH9+yp1tSqxhZRdeA=; b=O9JEl8DHVBkEK9fFTF4q5OoTwcZoBnm7R7uX5T9kia4PIWcb3UTsKEkne4d1/bNq+6uC/MXdDeiZ64RueGVhXmGqMytqiPX2WgbE1DEFne829G86fGAGQdqTyl3p1EWepYplZ1YzQAOydeQ/UVlHP29czLrhEeR46yCyLwVRRtMR0OgzDJFFBck87tym2rcOh54x5jesef2/yZI1QW7R00iESO298kdk+/1VfQKYnCKIvpjHqUdfPpNS2Ck/ZhzpZdv8i9L2EV816WKf3xAZRdSpWcWekXlGqzppqWXV40TIMAIFWzn4VvQGFAwU+IU4idmzHP1cRlje8p95H8ORKg==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JwNicM0MXbmAJx8wdyghKv0O4TJH9+yp1tSqxhZRdeA=; b=f+RnK+JNZFuVgU8qEKkkPY5ECgyP8F79M7kwDTN74iRSoAvZZHDt2BWPgNuBhM3crZJQL3ECHOfGOVuErt3fEtwEPfGzG3hBYfQOd9WXb1YAqh/quC9G2u3h+D++x15jK2rZ/VSpvSJDQWy4zBUOQaCjFHlr2qoGZDbSOSu3J6Q/27e+73dAD7Nhc8VQsWLPNWCAi9bpi6V+wQFuMk+I7yw17iIJQ84IVqNOIOm3oO5c9NtBDNY33eX0gPdPZOlbO5mIfCUlSSOwX/J8oAfhTnj/Ck+agEBzWD1WKosuQq4jh1/n+ZPWhhgWb3TSREsTT5OIALbSoA1Vpyci5sAAMw==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=XfPo7YUEHfBGIC9dEl4elXkpxR3qKUlpPIalCxiLeUX6aV0XxKfTahrubjBtJByYN55CzXcflTlym1nV/vqwwtkYVcXJzaAjfzfz+4QfQSTU1jUX5MueBHKcyJaaa4ktN1yhhZvWMXUoMsNiKd6iBwagnxTugaT76jpP+2To2lw0iuSjNx2maYAdhTN9o4PYHqzUN4af6tk7pqUiFz3OagKAU7omrRtzjSG6ONlxNm2qMagiTnhRrN8RaWaD5M8YAtYN8LaHE2FTWrW/prMQufXh24jMP5HHKnu0lTI/5lrrA6FTwCPsKpvedqAQwDDoybyDL3SVh/LLke2Ygkjk5Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=RLsLKJCS0jvR+VeK7PagtVt9Fvlv0zPUJtOxRtO7hvuUn1QETrJtLiOkecIP0oaaawwvKzeUCxTn5hXYuSkg0B9cvO7OcrsQDrkkE7+AxKH7zVu4iyMbBlj1O0K2jm8iA/NrFXDIxigEdvDAQ+9UaCPPQYg4Zt0L7d9Run5y1B6sESHel3G28fQBDqX0Xxec1POwV6rWzWmjMfooeFX79h4DuZk7liq++oBrYVAPKd7P4r3p4oE+o36uZfTi0B8bvvcenxPhWc7ivUL/m0Lv6EanJVgAUC1LBF5VYyfQOqPigaRXFbjr7dkafnpBaK3BqfhkC9hKMYcZQjkDwLnRyg==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=arm.com header.i="@arm.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"; dkim=pass header.s=selector1 header.d=arm.com header.i="@arm.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Delivery-date: Wed, 15 Apr 2026 15:10:09 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Thread-index: AQHczMxII8OnvwK6REKHyMHK6ZFZCLXgOc+A
- Thread-topic: [PATCH 4/6] xen/dt-overlay: fix silent success in dt_overlay_remove_node
Hi Michal,
> On 15 Apr 2026, at 12:36, Michal Orzel <michal.orzel@xxxxxxx> wrote:
>
> dt_overlay_remove_node() silently returns 0 when the target node is not
> found in the parent's sibling list. The loop simply exits without
> matching and falls through to "return 0", making the caller believe the
> node was successfully removed.
>
> Return -ENODEV after the loop when no match is found, and change the
> found-path from break to an explicit return 0 so the two outcomes are
> distinct.
>
> Fixes: 7e5c4a8b86f1 ("xen/arm: Implement device tree node removal
> functionalities")
> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
> ---
Looks ok to me
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
Cheers,
Luca
|
