Re: [PATCH 2/6] xen/dt-overlay: fix rangeset leak and dead code in domctl path

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Wed, 15 Apr 2026, Luca Fancellu wrote:
> Hi Michal,
> 
> > On 15 Apr 2026, at 12:36, Michal Orzel <michal.orzel@xxxxxxx> wrote:
> > 
> > handle_attach_overlay_nodes() unconditionally creates new rangesets
> > without checking whether they already exist from a prior attach. A
> > repeated attach for the same overlay leaks the original pair. Reject the
> > operation with -EEXIST if rangesets are already present.
> > 
> > Also, dt_overlay_domctl() early-returns -EOPNOTSUPP for any operation
> > other than ATTACH, making the if/else at the bottom unreachable. Remove
> > the dead branch.
> > 
> > Fixes: 4c733873b5c2 ("xen/arm: Add XEN_DOMCTL_dt_overlay and device 
> > attachment to domains")
> > Reported-by: Jan Beulich <jbeulich@xxxxxxxx>
> > Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
> > ---
> 
> Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>

Acked-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>