[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/6] xen/dt-overlay: fix rangeset leak and dead code in domctl path
- To: Michal Orzel <michal.orzel@xxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Wed, 15 Apr 2026 15:05:53 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=amd.com smtp.mailfrom=arm.com; dmarc=bestguesspass action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Wo/T6ByA8fqWtDlMUx4LiAYm7Wr4gCGAllXZXFM8KNE=; b=qhdBNPZNeAJnPCVwDKMkUORHxkqNCVsY3bRSu6p25OHpb5iXVGGdvkBjJ9/e6wT7ocKZ7J4iS+bZ3e2Iohk8cJPKHolaAL/6xNq3rRmIiSIzBtundqb577hBaw2PJRLBLioGfq7uMKggfsJkaqY133CKVTfxLnj8pdwlh0Riia7cFr87g3DEeg/9nX7m0JxxEtF8f/yx52vQrUdLGieWDZtbsV/YTQpVQP/bZFz7Oa834fB1cSKp2amAYbPWqlS9JM+IGxVczo6ckF4Yjtww4jPOVTGpfM6Lq0Rq/I+/dkD7m2LtrQhatbPbfJP6eCc7hXwRlH7QkoXi9zEaKkWeGA==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Wo/T6ByA8fqWtDlMUx4LiAYm7Wr4gCGAllXZXFM8KNE=; b=xwjmYnQWDpGuOSbsiDM2gOTPWUYi3IO8eUqLqeD6Ov9wiZ6Dfl6I9aCGSdGiQEq3AaL5z+oVxAEUUKlNHQKXQW4nld6c7OqnBz+w4JK2QMDosvLkpNJQKxR0hMQQSvz9qV7lidavWxaL/izhO4qIYTK+Qvy3Ov8BCTvUDC57Y+NbFF4I7lvV8FqPdxRwh7nWn3kVSO0ErrbfyOVLudg1OmSKd5x5Rm6T4U8LNehm9A5s8LkXVThHO402RJRDa4yL915Nl4PSlBiHe52VL5JL85rApVWrv8YuYR0yzNW+/uXMyE5jHMiyXDD9ysaLauhVt2U0o3LYte6t//2IAkWC2g==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=kmhHU+gDiTOVsVNCsBcLJV/c+Qba7qr5lvV70IqJZRJUqIcFeaee485ue03JQOy0wlAP788gBOaKAl8jA09S5NmGEjC43W0WjrW6+jup51bCKe9KX9HYyPRb5AVSAET4Qrf0h7PRnaODNKAypxe8CrSgkDpOEF+6+WYA4BEY0OFP1bIrOaCVCzQ5Itofcv6ixxaIEv2EMqnsyk4XaHy9oHLwx6LB5QjKup+E7LFGsWYFWfyOSVvBLloqWbw1+RwucWyetrLKx3WxujZX1jFolgX7nXVmdEBTn3KIOlOR4wKxxdbcUz2Jm/z4nTxYWyvOq8sCA7OX2j54Hq/8ogAP9g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ex/A+Nf7UCgOO35X3PCk1RH7HqJCTmEOnN9DPTapkrW3TlBpbQp+VzmGevR2OCXOlGXu2JoDK2MlqhRtalJJSJ19AxEc9ZDDDuHt8tj5cq06yClyD25GCUv1i59AD1NuxRzn90GYzRVrmRzZqE7p6GeD10GnDWlLCKKfD5mE1JlV7q9E6h8bJ4I9tp+YfOp4Es1spcu/sF88VlfGxLKMbRpnXnN1Tzagtkd2pH8kwXhN0fRv01Fm+EuYEhaYhfhFTHN1hkfp3CoKGup7mNJ/YlM+/99HfMmKiAX5ITRD/ZDHLJhENb/X7r5VKRAfqG8qe0Ceo7Eztxr4D7uCp58sjA==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=arm.com header.i="@arm.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"; dkim=pass header.s=selector1 header.d=arm.com header.i="@arm.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>
- Delivery-date: Wed, 15 Apr 2026 15:07:08 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Thread-index: AQHczMxIjpIzSUmpeUSPrgyPaY80gLXgOPiA
- Thread-topic: [PATCH 2/6] xen/dt-overlay: fix rangeset leak and dead code in domctl path
Hi Michal,
> On 15 Apr 2026, at 12:36, Michal Orzel <michal.orzel@xxxxxxx> wrote:
>
> handle_attach_overlay_nodes() unconditionally creates new rangesets
> without checking whether they already exist from a prior attach. A
> repeated attach for the same overlay leaks the original pair. Reject the
> operation with -EEXIST if rangesets are already present.
>
> Also, dt_overlay_domctl() early-returns -EOPNOTSUPP for any operation
> other than ATTACH, making the if/else at the bottom unreachable. Remove
> the dead branch.
>
> Fixes: 4c733873b5c2 ("xen/arm: Add XEN_DOMCTL_dt_overlay and device
> attachment to domains")
> Reported-by: Jan Beulich <jbeulich@xxxxxxxx>
> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
> ---
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
Cheers,
Luca
|
