[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 14/23] xen/arm: vIOMMU: IOMMU device tree node for dom0


  • To: Milan Djokic <milan_djokic@xxxxxxxx>
  • From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
  • Date: Mon, 13 Apr 2026 11:46:56 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=epam.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qx7CM4GUeTJ+yHQCO4Wz5NMdfHnS3Bcg8ShdcYvUV8A=; b=ZYSPBzbN6eM3tEZHBmXVSxBtqAq+XVcwautsD2oRkqYIwuGdbJ3BvsVyFRuVAG0vdkpJFP+o/Bp6GUyM8L23zYGCIXCMJ2QsKWgGwwi0DFV0FxKB695g/OKsPDDEX/z297AqKG4xjkKbvnAkKCvcOo3EJ1JdwaUvyvjj8Hp1jPBXZGaT3GNgu+Ygs8qXGLNFYDCz8xUbDZavHiiN4JcCWYOyP8dYeQhb1vO/858gEMq+2HnDdLudsKie7u3WasXlhTU8H9+J3CefMnz6b3VWnC9o0i7/IGDzsYucH9N7DHOWwZ97x9ohpBlgmSxDms455IBNOeySN2ZhE3eZvuiocw==
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qx7CM4GUeTJ+yHQCO4Wz5NMdfHnS3Bcg8ShdcYvUV8A=; b=phi7jQrzWC3rMwmhzSGduCCtugfGfNAqFx+1V3/B4a5Y96hBNi2z7Kd6f8alyIMk/0RlVFO4C3bNguQMFfuMPnUlaIokqB2VDCCGkqXbc+Puw/U/WhOx3pJEsE7bHlQ65gbRCS9X+3NluhBDh4NDPvomuLCMGlIKBK8M/uWsJ+KGphagAww4l6+lHQwTqF5xQlYc2+Q17cSpLNQRg8Mw/Va6OKqdLy0QGZPTyAYRApLoi87g/qMbc8SSifISIivhMeh0xUS/N2rA2MpmsugQpfWCB0KfX80vbhbExAfnOTua+85QTKwRGVInqjq2SRvZG6ArAznweXIhenPT094Jag==
  • Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=q9ja0OFGWmfzdZMVempoDKAtq4nXmUEQ/zwAfZ6l6t4KouIJ7fzHb9gsqDRlDxjMWpVjbmuYLQEqhiZXJjyOl5hwaTAICrfS3ee7lFJGONx02H4zhzOXZO7ii52z5SxqE+9x7kXOqu49Ruvzs0dWPxdsMBnbVRNHmcweUYwumq87GJESJIBZkXGTfBkGeTjvw2hGVUE59qSyaJkLnz5RFqix+Z2+bapp036a3KB/atPm1iAKjmdVV3iB9IhRDykcQRodIlOqGmtE7WWgGrXimAHRncScN4F2ub+Zlu+6/DtTPp8Rmlp7DUIUXTqR6H/cDPx2uRia5y1Z1sA6rGg3Dg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=lhYueQRbBS3K/5HUzWHh/SV6jMZWbuopbSpCs6SJ87q2zAEBXRIR7JFnzqhPJT6KZ63pywkjHdH413Qd7K1iopY2miGLfwVnvmMjXan1h2OciJLuyWz32bb3jTPiuBhPPeEmyOb2SgugLkzo4ppKBTAAPuFutPyhTB47f/rzSGFp8rMebGm4oJxv0shHD/4qbqhrL+6jASvig+92HTp4sQJ+Z9aLZtXK37Yz15pvjZKNuj3RdLr+sqbyUviHr0lveNV9x8jDNU/VF/lRVMpHz0HCfDdxNw31fIv4Aj6cpIIs6+hblrqoa3yLMEUS3F+FCagLGyrdDWQuzHyjyKNABw==
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=arm.com header.i="@arm.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"; dkim=pass header.s=selector1 header.d=arm.com header.i="@arm.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
  • Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Rahul Singh <Rahul.Singh@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Mon, 13 Apr 2026 11:48:12 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Thread-index: AQHcyzs6VJb6/zH3nkySmP47A5N2jg==
  • Thread-topic: [PATCH v3 14/23] xen/arm: vIOMMU: IOMMU device tree node for dom0

Hi Milan,

> On 31 Mar 2026, at 02:52, Milan Djokic <milan_djokic@xxxxxxxx> wrote:
> 
> From: Rahul Singh <rahul.singh@xxxxxxx>
> 
> XEN will create an IOMMU device tree node in the device tree
> to enable the dom0 to discover the virtual SMMUv3 during dom0 boot.
> IOMMU device tree node will only be created when cmdline option viommu
> is enabled.
> 
> Signed-off-by: Rahul Singh <rahul.singh@xxxxxxx>
> Signed-off-by: Milan Djokic <milan_djokic@xxxxxxxx>
> ---
> xen/arch/arm/domain_build.c       | 94 +++++++++++++++++++++++++++++++
> xen/arch/arm/include/asm/viommu.h |  1 +
> 2 files changed, 95 insertions(+)
> 
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index 30a4f1fd09..54ae3b5033 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -1440,6 +1440,95 @@ int __init make_timer_node(const struct kernel_info 
> *kinfo)
>     return res;
> }
> 
> +#ifdef CONFIG_ARM_VIRTUAL_IOMMU
> +static int make_hwdom_viommu_node(const struct kernel_info *kinfo)

__init ?

The rest looks ok to me, with that fixed:

Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>

Cheers,
Luca




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.