[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 15/23] xen/arm: vsmmuv3: Emulated SMMUv3 device tree node for dom0less
- To: Milan Djokic <milan_djokic@xxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Mon, 13 Apr 2026 11:50:13 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=epam.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5YwGIOcxhYngTLwhIGyiIMx6vouGo3F+MNrV+Lkof/8=; b=CIFrSkiET6+FPlf/CSTMdXrwCTZou8JBBZ2WI8JejLgpvvQGQAgrFz8egn5iZFuUzNgJu9ladNUerfNsuhTXNc71dok0M8FXa/jBCTEVnGJ6PiICau3UfGHHCjLODzy+Wz9G+qakRH/9z3hu/TKILCw37BCm72vxJ6N+iEHUQ4C2P8vbtoBY13dPc8F+hRXxGfKtCte/NdnGPhs5QAdXbKJhOKZ/WouIaRWFdI7EYxsMuUI8Y9cdd5fWxFiDoDAOBn1Ay19RUmQuZa9eDNhXwUTxI6xsiZGGnJ0IthuRLpiEpnWrAwM0QQ/H3N02Z7HgrVNeqZpI4jTnaoDeA3MfAA==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5YwGIOcxhYngTLwhIGyiIMx6vouGo3F+MNrV+Lkof/8=; b=ni3JbeJtXwurtiO7alZidsWtKLF9Sh6pmSZVR3/IbPdYGg0QeiIhJ0tOyVNstHRKTTex+1N8cuZuauS/ZX4fmeN7oOIKtKmmYuZQRZJGFXxy1qdUUhy4W1h7nMB1AHsWYW+jr1EWTxh7BUCs/MOd93o6Ykwh0mr6kEBjLnmj118t6qg+YU6uNxBw90TD5sbe+XZbBimfUSbfvL+WXEjKBhtnwPNnKQ82m27o3KlJlqJiQsAfA/L3ynM4lHYVe0Gy8WH1gV4rS1v/VgG3u3oHejbpkW+hhrMswPlFgNkiTXiXCXE/lqk3ZejzdH22WSf6wY+2yM/Ajuab8nMUV24WHQ==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=xZNQVCzCKkXZPF9ecR6BtXQFLFJZvs0SeAoR4SLmsMwSI2JAK3na7TBfWkF03DtRo7/3CPGQ1rMCpye8fDItxPj+Z3+ByLH/o2DGGblDQI8kmnqNwl3FCfwMv6l7JVHB16gxXx03hViqU2L2dAHRqZYEz+CEWnXlgNnHuZIYp213Wf5LJoEZOPmRvbhg48/7HA+ZhDvpnozunwMxq+g7tN4KGLx7lk7NyhgoOxZXUs0x4uqGuw8QIARIZh2qrb01qh6nBOvKvV8AQ3vEpg5Xk/X8tN+FpmO1zfQrf82Ysh7WdKix+hsDWftVt4HQ1b0g1vXXnTNkwO67rfL5Y8Kulw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=VatQjqs56JPiMH8ucqBUnCMDKw/NoDoL3CYcM5suzhLjoUCsrGIYIpGYjX/uc7tPN3VrBL78IJtVApTynWR/2IC6sSbSO/SwlH8OtbQ2zdLjK4P75TlmgFF5qA42kSJCBCNQfvWgW3KE5DxUMO4mhJTXL0yl+DBN9jVaoGUKJB3wBHbz2bWmn392jFrCsQfVylPiZpEGl94cwuJ28WLxPW/bZrpQqGjLNbK66B06Uc630SMlj7qSalP2CRJZkHpZJyQ5F0shMmdFy0NRfsafxXn4n1OtRopjLcfFtBwrJdZ4r1yVelfdjhib9dcQbfx+KxfeAUaZwHlZgEPvx2asRg==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=arm.com header.i="@arm.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"; dkim=pass header.s=selector1 header.d=arm.com header.i="@arm.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Rahul Singh <Rahul.Singh@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Mon, 13 Apr 2026 11:51:33 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Thread-index: AQHcyzuw/Pcnjl0pp0C7t77+0BHaBQ==
- Thread-topic: [PATCH v3 15/23] xen/arm: vsmmuv3: Emulated SMMUv3 device tree node for dom0less
Hi Milan,
> On 31 Mar 2026, at 02:52, Milan Djokic <milan_djokic@xxxxxxxx> wrote:
>
> From: Rahul Singh <rahul.singh@xxxxxxx>
>
> XEN will create an Emulated SMMUv3 device tree node in the device tree
> to enable the dom0less domains to discover the virtual SMMUv3 during
> boot. Emulated SMMUv3 device tree node will only be created when cmdline
> option vsmmuv3 is enabled.
>
> Signed-off-by: Rahul Singh <rahul.singh@xxxxxxx>
> Signed-off-by: Milan Djokic <milan_djokic@xxxxxxxx>
> ---
> xen/arch/arm/dom0less-build.c | 53 +++++++++++++++++++++++++++
> xen/include/public/device_tree_defs.h | 1 +
> 2 files changed, 54 insertions(+)
>
> diff --git a/xen/arch/arm/dom0less-build.c b/xen/arch/arm/dom0less-build.c
> index 067835e5d0..a48edb9568 100644
> --- a/xen/arch/arm/dom0less-build.c
> +++ b/xen/arch/arm/dom0less-build.c
> @@ -218,10 +218,63 @@ static int __init make_vpl011_uart_node(struct
> kernel_info *kinfo)
> }
> #endif
>
> +#ifdef CONFIG_VIRTUAL_ARM_SMMU_V3
> +static int __init make_vsmmuv3_node(const struct kernel_info *kinfo)
> +{
> + int res;
> + char buf[24];
> + __be32 reg[GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS];
> + __be32 *cells;
> + void *fdt = kinfo->fdt;
> +
> + snprintf(buf, sizeof(buf), "iommu@%llx", GUEST_VSMMUV3_BASE);
PRIx64 ?
The rest looks ok to me, with that fixed:
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
Cheers,
Luca
|
