[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 11/12] xen: Bracket uses of macro parameters
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- Date: Fri, 20 Feb 2026 23:45:18 +0100
- Arc-authentication-results: i=1; bugseng.com; arc=none smtp.remote-ip=162.55.131.47
- Arc-message-signature: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; c=relaxed/relaxed; t=1771627518; h=MIME-Version:Date:From:To:Cc:Subject:In-Reply-To:References: Message-ID:X-Sender:Organization:Content-Type: Content-Transfer-Encoding; bh=ZuT8Al7qRVwTf+zcSkcaotR4xT/ASXYI3j/VG1xYTKk=; b=5NlwkaeKzYZxZrHoAyyQIaa3WPi6jTxXqF57aykLSXzJl+c2uzrPJBUPkCQY83FrWbuu Yj/Io3SEFQJmmMJq/4oDOKGQBqhPhvYl8mWdNs85F0FAcL9VAr1hutgoctxhgq5c9WzFC 335lw6z7xm8vRUY1N7cU6D04TH7cRd2U9KPCMi6ZGqbenV3goo4IpuaZpLw4KOv5SxNd5 71OinRRGPzMx4dvWNcYroxibxSu8BT4PCIz8kWu/lFYKf5GM1+JaGBuvLt5THreNGkaZd 0oF4+RudnavWeqabQaHCv2OEzUopYuht7LKaCh2d8r9aoQlezPw7gwDSc+IJyfxpVVfDD nzm2ee24t4fAJ7yu8/Kf+vRQP7NkAW8vtaF2cSQcltt/6/4/D3YQYxI/Fw475Q9qSZaem 5UQ2Dn9pz6d9/EPwz7fr1xZKZvyWNsUYRWpsln6wILjveSw0wfqHCSkf462eQgoMSvKFe asBidUpYbRaJwHpfGOnrzyiam/zbbnkuYofntDVUV4eG5gIj+rlEanwzcudXrTsoYCRl4 Jil3oVUJtwMAOSYA1eRTJo4sOrgoLE02f56JGVcExZfIYXIKNPIlMzAyFYHn9EEGQaKRM KRmlc+qNcpS/UDNE5zyJFLGS40wvnAUWxpBlYAxSbIGsYB6m066FegXMN+e5fKM=
- Arc-seal: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; cv=none; t=1771627518; b=NOFuQ7+omLDGjNeLnuRxqTNmI4VaTtauhFQKzfcO1nq9oi+XFvKOD3b8eCQqFlLo+Qfb d34tWecO9w0IXW6suhYXiN7SZNbkhj1PJQ2L0bjO8iJiYBZDX+ABHqLDtHieIG3NG93lq owPHsu1AYc48PsIaiMUxVagfLYMUDkIJBBIucDbM1sN6fXp1+RWuOESDTWPP22F6H1SpI dU2XnngbJS220iwZh5/8F/PRMsuchA1VcW/UPUeZvhOTOZKoEKPxjw9yr/B8IDNIcuNSA J7PsMoetNh2msfr0fJewNMWvTXTdFndKdiCIyCLGaFsH2Y/yfnN7P41ainN2q+fC5THAi wbYWJXHtd0xHV1ml3+rm20/kzl6k7Hq4GQGOxMzNIPAQgZ/JuAa9ey6FBwjXNjNZwYDU5 qp2BZM8AzlX3peKTPkmRa5us1xlmWjp/ZM385iH090TT/uFaewc+JH32Y9CoiPebRFymm Arx3R2hav1TJFaa3tFlwrpm/BZfEhUvbovjsYnvomg8NpWa4faxLvX2wWeSCpxBNk2+W3 kyfjrkqe4sDDsCI5tB5H3451DJT2vnAx9CdKmAyyVQwEP/+De36vMi/9oZsTVBP61ldOv hpiCs9XbvXDrfjKvumOqq5l3YpTmeuCYUSlzy/eJSMyHTjKazrsb9fyFmxfLCL8=
- Authentication-results: bugseng.com; arc=none smtp.remote-ip=162.55.131.47
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, "consulting @ bugseng . com" <consulting@xxxxxxxxxxx>
- Delivery-date: Fri, 20 Feb 2026 22:45:27 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 2026-02-20 22:46, Andrew Cooper wrote:
Fixing Rule 20.7 violations.
No functional change.
Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Reviewed-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
Two minor nits below
---
CC: Jan Beulich <JBeulich@xxxxxxxx>
CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
CC: Stefano Stabellini <sstabellini@xxxxxxxxxx>
CC: Julien Grall <julien@xxxxxxx>
CC: Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
CC: Bertrand Marquis <bertrand.marquis@xxxxxxx>
CC: Michal Orzel <michal.orzel@xxxxxxx>
CC: consulting@xxxxxxxxxxx <consulting@xxxxxxxxxxx>
CC: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
---
xen/arch/arm/pci/pci-access.c | 6 +++---
xen/arch/x86/include/asm/bootinfo.h | 2 +-
xen/arch/x86/mm/shadow/multi.c | 2 +-
xen/common/kimage.c | 11 ++++++-----
xen/common/livepatch.c | 11 ++++++-----
xen/crypto/vmac.c | 8 ++++----
xen/include/xen/libfdt/libfdt.h | 6 +++---
7 files changed, 24 insertions(+), 22 deletions(-)
diff --git a/xen/arch/arm/pci/pci-access.c
b/xen/arch/arm/pci/pci-access.c
index 2b23d552bbfb..7bd6877596d4 100644
--- a/xen/arch/arm/pci/pci-access.c
+++ b/xen/arch/arm/pci/pci-access.c
@@ -16,7 +16,7 @@
#include <asm/io.h>
#define INVALID_VALUE (~0U)
-#define PCI_ERR_VALUE(len) GENMASK(0, len * 8)
+#define PCI_ERR_VALUE(len) GENMASK(0, (len) * 8)
static const struct pci_ops *get_ops(struct pci_host_bridge *bridge,
pci_sbdf_t sbdf)
@@ -139,14 +139,14 @@ static void pci_config_write(pci_sbdf_t sbdf,
unsigned int reg,
void pci_conf_write##size(pci_sbdf_t sbdf, \
unsigned int reg, type data) \
{ \
- pci_config_write(sbdf, reg, size / 8, data); \
+ pci_config_write(sbdf, reg, (size) / 8, data); \
}
#define PCI_OP_READ(size, type) \
type pci_conf_read##size(pci_sbdf_t sbdf, \
unsigned int reg) \
{ \
- return pci_config_read(sbdf, reg, size / 8); \
+ return pci_config_read(sbdf, reg, (size) / 8); \
}
PCI_OP_READ(8, uint8_t)
diff --git a/xen/arch/x86/include/asm/bootinfo.h
b/xen/arch/x86/include/asm/bootinfo.h
index 4f2cc5906e59..b3a6b2acf3ac 100644
--- a/xen/arch/x86/include/asm/bootinfo.h
+++ b/xen/arch/x86/include/asm/bootinfo.h
@@ -75,7 +75,7 @@ static inline unsigned int __init
next_boot_module_index(
#define for_each_boot_module_by_type(i, b, t) \
for ( (i) = first_boot_module_index(b, t); \
(i) <= (b)->nr_modules; \
- (i) = next_boot_module_index(b, t, i + 1) )
+ (i) = next_boot_module_index(b, t, (i) + 1) )
#endif /* X86_BOOTINFO_H */
diff --git a/xen/arch/x86/mm/shadow/multi.c
b/xen/arch/x86/mm/shadow/multi.c
index 3bbaceec1287..9de60720db20 100644
--- a/xen/arch/x86/mm/shadow/multi.c
+++ b/xen/arch/x86/mm/shadow/multi.c
@@ -793,7 +793,7 @@ do {
\
do {
\
int __done = 0;
\
_FOREACH_PRESENT_L1E(_sl1mfn, _sl1e, _gl1p,
\
- ({ (__done = _done); }), _code);
\
+ ({ (__done = (_done)); }), _code);
\
_sl1mfn = sh_next_page(_sl1mfn);
\
if ( !__done )
\
_FOREACH_PRESENT_L1E(_sl1mfn, _sl1e, _gl1p, _done, _code);
\
diff --git a/xen/common/kimage.c b/xen/common/kimage.c
index e1aec5a18a54..972301368443 100644
--- a/xen/common/kimage.c
+++ b/xen/common/kimage.c
@@ -491,11 +491,12 @@ static void kimage_terminate(struct kexec_image
*image)
* Call unmap_domain_page(ptr) after the loop exits.
*/
#define for_each_kimage_entry(image, ptr, entry)
\
- for ( ptr = map_domain_page(_mfn(paddr_to_pfn(image->head)));
\
- (entry = *ptr) && !(entry & IND_DONE);
\
- ptr = (entry & IND_INDIRECTION) ?
\
- (unmap_domain_page(ptr),
map_domain_page(_mfn(paddr_to_pfn(entry)))) \
- : ptr + 1 )
+ for ( (ptr) = map_domain_page(_mfn(paddr_to_pfn((image)->head)));
\
+ ((entry) = *(ptr)) && !((entry) & IND_DONE);
\
+ (ptr) = (((entry) & IND_INDIRECTION)
\
+ ? (unmap_domain_page(ptr),
\
+ map_domain_page(_mfn(paddr_to_pfn(entry))))
\
+ : (ptr) + 1) )
static void kimage_free_entry(kimage_entry_t entry)
{
diff --git a/xen/common/livepatch.c b/xen/common/livepatch.c
index 7446533c8cfb..63473925cafb 100644
--- a/xen/common/livepatch.c
+++ b/xen/common/livepatch.c
@@ -664,9 +664,10 @@ static inline int
livepatch_check_expectations(const struct payload *payload)
const struct livepatch_elf_sec *__sec =
livepatch_elf_sec_by_name(elf, section_name); \
if ( !__sec )
\
break;
\
- if ( !section_ok(elf, __sec, sizeof(*hook)) || __sec->sec->sh_size
!= sizeof(*hook) ) \
+ if ( !section_ok(elf, __sec, sizeof(*(hook))) ||
\
+ __sec->sec->sh_size != sizeof(*(hook)) )
\
return -EINVAL;
\
- hook = __sec->addr;
\
+ (hook) = __sec->addr;
\
This is not strictly needed, if not for consistency
} while (0)
/*
@@ -678,10 +679,10 @@ static inline int
livepatch_check_expectations(const struct payload *payload)
const struct livepatch_elf_sec *__sec =
livepatch_elf_sec_by_name(elf, section_name); \
if ( !__sec )
\
break;
\
- if ( !section_ok(elf, __sec, sizeof(*hook)) )
\
+ if ( !section_ok(elf, __sec, sizeof(*(hook))) )
\
return -EINVAL;
\
- hook = __sec->addr;
\
- nhooks = __sec->sec->sh_size / sizeof(*hook);
\
+ (hook) = __sec->addr;
\
+ (nhooks) = __sec->sec->sh_size / sizeof(*(hook));
\
same as above
} while (0)
static int prepare_payload(struct payload *payload,
diff --git a/xen/crypto/vmac.c b/xen/crypto/vmac.c
index c9914d2c7c1d..c7aa1e9be3b9 100644
--- a/xen/crypto/vmac.c
+++ b/xen/crypto/vmac.c
@@ -203,7 +203,7 @@ const uint64_t mpoly =
UINT64_C(0x1fffffff1fffffff); /* Poly key mask */
#define nh_16(mp, kp, nw, rh, rl)
\
{ int i; uint64_t th, tl;
\
rh = rl = 0;
\
- for (i = 0; i < nw; i+= 2) {
\
+ for (i = 0; i < (nw); i+= 2) {
\
MUL64(th,tl,get64PE((mp)+i )+(kp)[i
],get64PE((mp)+i+1)+(kp)[i+1]);\
ADD128(rh,rl,th,tl);
\
}
\
@@ -211,7 +211,7 @@ const uint64_t mpoly =
UINT64_C(0x1fffffff1fffffff); /* Poly key mask */
#define nh_16_2(mp, kp, nw, rh, rl, rh1, rl1)
\
{ int i; uint64_t th, tl;
\
rh1 = rl1 = rh = rl = 0;
\
- for (i = 0; i < nw; i+= 2) {
\
+ for (i = 0; i < (nw); i+= 2) {
\
MUL64(th,tl,get64PE((mp)+i )+(kp)[i
],get64PE((mp)+i+1)+(kp)[i+1]);\
ADD128(rh,rl,th,tl);
\
MUL64(th,tl,get64PE((mp)+i
)+(kp)[i+2],get64PE((mp)+i+1)+(kp)[i+3]);\
@@ -223,7 +223,7 @@ const uint64_t mpoly =
UINT64_C(0x1fffffff1fffffff); /* Poly key mask */
#define nh_vmac_nhbytes(mp, kp, nw, rh, rl)
\
{ int i; uint64_t th, tl;
\
rh = rl = 0;
\
- for (i = 0; i < nw; i+= 8) {
\
+ for (i = 0; i < (nw); i+= 8) {
\
MUL64(th,tl,get64PE((mp)+i )+(kp)[i
],get64PE((mp)+i+1)+(kp)[i+1]);\
ADD128(rh,rl,th,tl);
\
MUL64(th,tl,get64PE((mp)+i+2)+(kp)[i+2],get64PE((mp)+i+3)+(kp)[i+3]);\
@@ -237,7 +237,7 @@ const uint64_t mpoly =
UINT64_C(0x1fffffff1fffffff); /* Poly key mask */
#define nh_vmac_nhbytes_2(mp, kp, nw, rh, rl, rh1, rl1)
\
{ int i; uint64_t th, tl;
\
rh1 = rl1 = rh = rl = 0;
\
- for (i = 0; i < nw; i+= 8) {
\
+ for (i = 0; i < (nw); i+= 8) {
\
MUL64(th,tl,get64PE((mp)+i )+(kp)[i
],get64PE((mp)+i+1)+(kp)[i+1]);\
ADD128(rh,rl,th,tl);
\
MUL64(th,tl,get64PE((mp)+i
)+(kp)[i+2],get64PE((mp)+i+1)+(kp)[i+3]);\
diff --git a/xen/include/xen/libfdt/libfdt.h
b/xen/include/xen/libfdt/libfdt.h
index fabddbee8cec..1b09bba28eea 100644
--- a/xen/include/xen/libfdt/libfdt.h
+++ b/xen/include/xen/libfdt/libfdt.h
@@ -230,9 +230,9 @@ int fdt_next_subnode(const void *fdt, int offset);
* literal.
*/
#define fdt_for_each_subnode(node, fdt, parent) \
- for (node = fdt_first_subnode(fdt, parent); \
- node >= 0; \
- node = fdt_next_subnode(fdt, node))
+ for ((node) = fdt_first_subnode(fdt, parent); \
+ (node) >= 0; \
+ (node) = fdt_next_subnode(fdt, node))
/**********************************************************************/
/* General functions
*/
--
Nicola Vetrini, B.Sc.
Software Engineer
BUGSENG (https://bugseng.com)
LinkedIn: https://www.linkedin.com/in/nicola-vetrini-a42471253
|
