[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 10/12] xen: Adjust break/fallthrough statements
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- Date: Fri, 20 Feb 2026 23:36:01 +0100
- Arc-authentication-results: i=1; bugseng.com; arc=none smtp.remote-ip=162.55.131.47
- Arc-message-signature: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; c=relaxed/relaxed; t=1771626962; h=MIME-Version:Date:From:To:Cc:Subject:In-Reply-To:References: Message-ID:X-Sender:Organization:Content-Type: Content-Transfer-Encoding; bh=s2wppOSq5neXKBJRad5+bFHQtqi7vTyDBV9NWHmaybw=; b=y7lWxImlfEyw6qzShK8EP5SsHs59Vvtrd5P+qQ/aYbgk0cZ8xWIVS6AJhR2bpDT5yG8m 8qhCRNkt9jBaoRKsPGJQkFuZ+2U8YO5QSd1y7dgiQmgsN10qzfjuKKqrTl11Rr06s7Yzh xhv8KpsBsJWSXn+Vz/p2WFYnT3Lf2Cxkftp99woew2SSWXv5ba/3JAbBiNrIYfcdceHMk XboZVTBWExFXfN64It5LYOyK1ofpfF9yEVxJzMBpuqENizXnWMuFAfhgjqaDtdO+ePzk3 z+Y2kgHz4EOvi4EWsNfznZg1CSmJIh2MLhkqCIpqjvL+7MaE3vW2R271wcWtxMIEsl3Dn mIt9iVTPvVKzyrvJ5eUXQISI/cZgH9MAPBYY5I+nYyrLMQgikYXiL/UOBfEqwBBvdcqe1 yg7XWqVXmNh1N923iNdXz13Vy25zHqLVYaeo+4OCzCk+2X96RA8z4hQeLsASA+OMxVw/S 7+fEa+y57+rGF+6hejZa39/kIYqtcsHRm2iG9d7GB9sGfeczusyB/PNQozAPlKZk2ehf4 duptNznrfOlQp4sWlfrA1f1chibquBzgLTDJuqcp5iOVgIqAAu8yh31YtwTlqR0REXezi Hba+vIiSEOZp1l8gis2uMc3ChQbbsL4SDSpQBcpQHPFi6Vsy84TdMGuQTENUYsw=
- Arc-seal: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; cv=none; t=1771626962; b=ihIQGZ1EDvHB4wu0WRVp/urVYsxKrsnRsG6vqzdm1V8j6azEeKo2un9LDqH2+59XDLu2 lHVfYbmGHJHTu+/umSABdeVZ5VoYaQM6EWT6qmZ8C4UIVMIZGQdqhTBu65vea0Qs42u4Z e9LqzuuUlNzKja5231YWWhD+MuQsWo5GmMPfwuCcrW+g5pPzSQMevE46lFGF2Of5u3xWi F7OUU/pTMxlVNAFAY7loIInYR7JKXe9j+D6MSwngIVd1779Hye62n4/TXmSoyjWyRvP6A yQ23gKC+GwnKLspPv1j/3ncToJKOBdpTtStrIB5DE7ds5wuvDyV6xA/L3CdNumv5hmuga voY9edl/Tt0cTkF5KO0KHTznGPtLKN8EY+3Kja8YlXq7mSlfAfKvGGyH9GFnQVzQoUSDc QhxqldiKQ2ctUHJvoMlcySBTppMuwxBxxAfYvEwUVJUwnm4fk674GBsL0Vzze9NaJJQOn v6BG+id/76+ii1ZHcKYY/2jPZH0mN6r5DC2WfLKvK+58yzbrLLtxHb7qrLwqzw+wPX6vq N8tPsJ/1T9+qIn8n/yU4GjLeWLf24mTPQp20OE9DWpW8ZUh87pfWmjZw/EN1rlTUqOePW I0j5Y7v49UsNGd2nhQ1cz7CyTU/pkukyRI+rbiT1GaQIYSFM7K5NuZs2aY+Di/I=
- Authentication-results: bugseng.com; arc=none smtp.remote-ip=162.55.131.47
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, "consulting @ bugseng . com" <consulting@xxxxxxxxxxx>
- Delivery-date: Fri, 20 Feb 2026 22:36:13 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 2026-02-20 22:46, Andrew Cooper wrote:
sh_destroy_shadow() has a spelling of fallthrough which doesn't match
the
permitted pattern. Convert it to a real fallthrough (psedo)keyword.
Elsewhere, insert breaks at the end of the default statements.
No functional change.
Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Reviewed-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
---
CC: Jan Beulich <JBeulich@xxxxxxxx>
CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
CC: Stefano Stabellini <sstabellini@xxxxxxxxxx>
CC: Julien Grall <julien@xxxxxxx>
CC: Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
CC: Bertrand Marquis <bertrand.marquis@xxxxxxx>
CC: Michal Orzel <michal.orzel@xxxxxxx>
CC: consulting@xxxxxxxxxxx <consulting@xxxxxxxxxxx>
CC: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
---
xen/arch/arm/pci/pci-access.c | 2 ++
xen/arch/arm/pci/pci-designware.c | 2 ++
xen/arch/arm/tee/optee.c | 1 +
xen/arch/x86/mm/shadow/common.c | 2 +-
4 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/xen/arch/arm/pci/pci-access.c
b/xen/arch/arm/pci/pci-access.c
index c0533c00c9a5..2b23d552bbfb 100644
--- a/xen/arch/arm/pci/pci-access.c
+++ b/xen/arch/arm/pci/pci-access.c
@@ -63,6 +63,7 @@ int pci_generic_config_read(struct pci_host_bridge
*bridge, pci_sbdf_t sbdf,
break;
default:
ASSERT_UNREACHABLE();
+ break;
}
return 0;
@@ -89,6 +90,7 @@ int pci_generic_config_write(struct pci_host_bridge
*bridge, pci_sbdf_t sbdf,
break;
default:
ASSERT_UNREACHABLE();
+ break;
}
return 0;
diff --git a/xen/arch/arm/pci/pci-designware.c
b/xen/arch/arm/pci/pci-designware.c
index 6b85213f637b..902da19e8c98 100644
--- a/xen/arch/arm/pci/pci-designware.c
+++ b/xen/arch/arm/pci/pci-designware.c
@@ -48,6 +48,7 @@ static int dw_pcie_read(void __iomem *addr, unsigned
int len, uint32_t *val)
break;
default:
ASSERT_UNREACHABLE();
+ break;
}
return 0;
@@ -71,6 +72,7 @@ static int dw_pcie_write(void __iomem *addr, unsigned
int len, uint32_t val)
break;
default:
ASSERT_UNREACHABLE();
+ break;
}
return 0;
diff --git a/xen/arch/arm/tee/optee.c b/xen/arch/arm/tee/optee.c
index 699e8d536862..f719d9d767ab 100644
--- a/xen/arch/arm/tee/optee.c
+++ b/xen/arch/arm/tee/optee.c
@@ -1206,6 +1206,7 @@ static void do_call_with_arg(struct optee_domain
*ctx,
default:
/* Free any temporary shared buffers */
free_shm_buffers(ctx, call->xen_arg);
+ break;
}
put_std_call(ctx, call);
diff --git a/xen/arch/x86/mm/shadow/common.c
b/xen/arch/x86/mm/shadow/common.c
index 96986ee2553d..5834c265f76d 100644
--- a/xen/arch/x86/mm/shadow/common.c
+++ b/xen/arch/x86/mm/shadow/common.c
@@ -1213,7 +1213,7 @@ void sh_destroy_shadow(struct domain *d, mfn_t
smfn)
#ifdef CONFIG_PV32
case SH_type_l2h_64_shadow:
ASSERT(is_pv_32bit_domain(d));
- /* Fall through... */
+ fallthrough;
#endif
case SH_type_l2_64_shadow:
SHADOW_INTERNAL_NAME(sh_destroy_l2_shadow, 4)(d, smfn);
--
Nicola Vetrini, B.Sc.
Software Engineer
BUGSENG (https://bugseng.com)
LinkedIn: https://www.linkedin.com/in/nicola-vetrini-a42471253
|
