[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 11/12] xen: Bracket uses of macro parameters
- To: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Wed, 25 Feb 2026 16:05:12 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=J4pjHcQCEXlE1hsG7aVAN1IQGSVFjDbEoRBjVgBkl8I=; b=g4ro7OZ0Rj4dbdMkh36ejojD2dsS4kOXfWCzZc55HnSuAHap6hR19hxysSaH2PSyHtSveBrbyUYXokcs7MwnsI4ZI/uwjKv+l8NJXtpiqE3OVyfuQNJ651cAuDWZZ7Aq4h0K3qvHhSzPn3oPxGqmZvJMdRYPPc5QBZDJU8lnovJV4nvOaMl4VhJ/ysF+b8SzGpR2QU6irti5UZjs4CcnDoFgCADquKDy4LZG7tQOK2Fq8lghBlVjjL3QJ/tYwPqECV9Cxt1MMNR7rMNZzwEUUUqo963FkHJjbBJaMkHib0HPre0/YMfMS4vd+26zHpWFAXYqro5pAhW5aib2+hXNug==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=bHTowbhSclzQVxLkGY7zFiksPwEr209GfMdI9ZxA0QSBzlgxiEIY08Z6k6zPlKN9jrjmyvU4qe7zfJxLjznLYhidx6qHDz0Qb5nvct1cLQK7f31Z2cH4sNOwuoqNoIYG8zlfUctdpnYhAgL3nKIKkHLhJKhoWe4eWP9p7mzDoRqM1X6zYxzOZXuRsH0SX0sgyihQeXs9g1pWEPbtSwq6AQQbYNZNdLA1fxPoUKFcNoFuu+n1p5AXAzCgImozIy7eHPRfG3tFYlJF6npbkQe9KZK3GKcGSrQ+F1G0r9Y+Qo9HzKIFUfbBQshB4j/72J9fcQW3eeCPM7F7ZA51AKxUbw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, "consulting @ bugseng . com" <consulting@xxxxxxxxxxx>
- Delivery-date: Wed, 25 Feb 2026 16:05:24 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 20/02/2026 10:45 pm, Nicola Vetrini wrote:
> On 2026-02-20 22:46, Andrew Cooper wrote:
>> Fixing Rule 20.7 violations.
>>
>> No functional change.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>
> Reviewed-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
Thanks.
>> diff --git a/xen/common/livepatch.c b/xen/common/livepatch.c
>> index 7446533c8cfb..63473925cafb 100644
>> --- a/xen/common/livepatch.c
>> +++ b/xen/common/livepatch.c
>> @@ -664,9 +664,10 @@ static inline int
>> livepatch_check_expectations(const struct payload *payload)
>> const struct livepatch_elf_sec *__sec =
>> livepatch_elf_sec_by_name(elf, section_name); \
>> if ( !__sec
>> )
>> \
>>
>> break;
>> \
>> - if ( !section_ok(elf, __sec, sizeof(*hook)) ||
>> __sec->sec->sh_size != sizeof(*hook) ) \
>> + if ( !section_ok(elf, __sec, sizeof(*(hook)))
>> || \
>> + __sec->sec->sh_size != sizeof(*(hook))
>> ) \
>> return
>> -EINVAL;
>> \
>> - hook =
>> __sec->addr;
>> \
>> + (hook) =
>> __sec->addr;
>> \
>
> This is not strictly needed, if not for consistency.
That explains why my first try didn't succeed. But, why is it that only
MISRA only cares about bracketing for rvalues, not lvalues ?
~Andrew
|
