[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH for-4.21 4/6] tools/xl: check return value of printf_info_one_json() in list_domains_details()
- To: xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Roger Pau Monne <roger.pau@xxxxxxxxxx>
- Date: Wed, 15 Oct 2025 15:40:41 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tksbA7H2lMSaY3a5c9YU6hhiTitb1FxEL7gVnxGjj7U=; b=WhkWOnsYXmtBxI8C/0PEuamRPbu7Wo/wKCUltRUmCofoDr/hOZMAKRqI9uGNtTipS0eqE+de3gx9j/7Jp/n8NI4IYBQLOiIIOO4VhgpLlAGVUVMg4k4xEBG3ArtLAaJ+vHvXevDwDeGDbd/9N3Y7enMUg5tdj77URhbe6ZTFd6twSYDAf0GUjc5CSkSe76klcCYBwTdOuka6oujYY2vMOvMfCrXb86qBulVoN+ZQrX8DjPixS6ocFX8a0fvX5swaHXszjG6E7H3UhYRJvwmuHUlwxU3gAYXxfAU7xalzI+aRFKikM5/MyeseLK2bkKtwlT9poNOw5+yCWofPQ7zQVg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ymluJR4PiKjiUuFSOS8w2TKltw1DCPsIRqfhWGrW3w0Ymx3XmLkh9FszY9MgXtPTPhUfU3xABLcjNiONfMUudlYEPSElUynNJbF9FAPoiQUteE9wyQYcGgtHLPGpA/OSqAFKlpih31T9kpIb/h+6BYuQb17SwXc8PbgD9GmSMaIBpVN3ctbw5N3sYywBF0lRj1dd7XifB1H118jZ+VfaBJCZbsHE0JIkgPCMUJhrfzQ42y9Hr0Th+Rcal+Jh30fpkcFAZrSgKpxKWV/SdhBfKdD2zqL1Ejau5XskeJ0FGYLtzhmu1zImAi0G4obiURzJjsO/Rm3T+jH49vbD3COECA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: oleksii.kurochko@xxxxxxxxx, Roger Pau Monne <roger.pau@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Roger Pau Monné <roger.pua@xxxxxxxxxx>
- Delivery-date: Wed, 15 Oct 2025 13:48:10 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
And return from the function early if printf_info_one_json() returns error.
Reported by internal XenServer Coverity instance.
Fixes: f6c6f2679d49 ("libxl: Convert libxl__object_to_json() to json-c")
Signed-off-by: Roger Pau Monné <roger.pua@xxxxxxxxxx>
---
tools/xl/xl_info.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/xl/xl_info.c b/tools/xl/xl_info.c
index 2048669abbd4..696f1f7423cb 100644
--- a/tools/xl/xl_info.c
+++ b/tools/xl/xl_info.c
@@ -585,6 +585,8 @@ static void list_domains_details(const libxl_dominfo *info,
int nb_domain)
#ifdef HAVE_LIBJSONC
json_object *jso_value;
rc = printf_info_one_json(&jso_value, info[i].domid, &d_config);
+ if (rc)
+ goto out;
json_object_array_add(jso, jso_value);
#elif defined(HAVE_LIBYAJL)
s = printf_info_one_json(hand, info[i].domid, &d_config);
--
2.51.0
|
