[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 06/11] xen/arm/irq: allow eSPI processing in the do_IRQ function
- To: Leonid Komarianskyi <Leonid_Komarianskyi@xxxxxxxx>
- From: Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Date: Tue, 26 Aug 2025 22:30:35 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=G5aEdTGeTF2UQfLvyJ76QgFfbnTA5M0yROd91j/48qI=; b=ciYU2uhn+CJ3Atjc3902y40KlAwEwGYUnrMSmrN0BZfGC389Rqu9FDVHnCCPpmb3lKvcI7KQrdIltC8JAAGXdu+ttFtFMssS8L6pmVHJSnln7/uspOBVovAL2tyaehAkTpegFuRekHdZ8C1Zf/xq3Z5fOAMbaUNjJcAa04LEW4uainvtsbpLRGiLGOm/4wyM3q/9kpUg0ixV1pAfEpBZB2p2XTwk6B3sVKUxrHSS2lvEAgesHY1PT2w3FtoniW6UueNKEhqtD7abfIOtJbfLn8wzOjreClJMCkD/Uy3dbwsGAfHndgDg/OTqLaanF9vr10zE7YvhnCX1T+iQ2JOIyg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=lbZEW2mkBXDx3iQ2HnDOt1TZIufq28oZ9mQ6xSIhwF2oQ7sIm/lnT2zUEv2HiTdTN/dH3iyT8w54wADOAxI5VOSvGc0guQJF3K4IPIADqCv44h2dstQpysjFs7zHPk+wzEyFqGs45p59jiLaIppZf0v5XmqIqtd9bCtAIWE4LDoPOu67ZbFzj4UFIzyb0W+28fjzdZwdNvxntYTckk23O2G7ZvkS1PRy2dMv5z6/96LDPH917JpXOyrhXsuK+H0MbonaYDj93OSg+HqH/ZtynYQRgirH/162gkcpem3yxXnsWSkD3+tOi5uHcCiWcFpCFl+ujlOz6FJFduLPmXTKbQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "olekstysh@xxxxxxxxx" <olekstysh@xxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>
- Delivery-date: Tue, 26 Aug 2025 22:30:44 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHcFpJ/78TDbVIRnkOE9iNbqduJVA==
- Thread-topic: [PATCH v3 06/11] xen/arm/irq: allow eSPI processing in the do_IRQ function
Hi,
Leonid Komarianskyi <Leonid_Komarianskyi@xxxxxxxx> writes:
> The do_IRQ() function is the main handler for processing IRQs.
but you are making change to gic_interrupt() function... I think you
need to update the commit message and subject.
> Currently, due to restrictive checks, it does not process interrupt
> numbers greater than 1024. This patch updates the condition to allow
But check reads "irq < 1020"...
> the handling of interrupts from the eSPI range.
>
With commit message fixed:
Reviewed-by: Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>
> Signed-off-by: Leonid Komarianskyi <leonid_komarianskyi@xxxxxxxx>
>
> ---
> Changes in V2:
> - no changes
>
> Changes in V3:
> - no changes
> ---
> xen/arch/arm/gic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/arch/arm/gic.c b/xen/arch/arm/gic.c
> index b88237ccda..634b77c987 100644
> --- a/xen/arch/arm/gic.c
> +++ b/xen/arch/arm/gic.c
> @@ -341,7 +341,7 @@ void gic_interrupt(struct cpu_user_regs *regs, int is_fiq)
> /* Reading IRQ will ACK it */
> irq = gic_hw_ops->read_irq();
>
> - if ( likely(irq >= GIC_SGI_STATIC_MAX && irq < 1020) )
> + if ( likely(irq >= GIC_SGI_STATIC_MAX && irq < 1020) || is_espi(irq)
> )
> {
> isb();
> do_IRQ(regs, irq, is_fiq);
--
WBR, Volodymyr
|
